aboutsummaryrefslogtreecommitdiff
path: root/winsup/cygwin
AgeCommit message (Collapse)AuthorFilesLines
2019-07-25Cygwin: Don't change pgid to ctty pgid under debuggerCorinna Vinschen1-1/+5
_pinfo::set_ctty sets myself's pgid to the ctty pgid if the process has been started from a non-Cygwin process. This isn't the right thing to do when started from GDB. GDB starts the application via standard Windows means, not via Cygwin fork/exec, so it's treated as being a non-Cygwin parent. But we want the app running in it's own process group. So skip this step when running under a debugger Signed-off-by: Corinna Vinschen <corinna-cygwin@cygwin.com>
2019-07-24Cygwin: Export newlib ndbm functionsCorinna Vinschen3-1/+15
Signed-off-by: Corinna Vinschen <corinna-cygwin@cygwin.com>
2019-07-24Cygwin: document the last bug fixKen Brown1-0/+3
2019-07-24Cygwin: fhandler_termios::tcsetpgrp: check that argument is non-negativeKen Brown1-0/+5
Return -1 with EINVAL if pgid < 0. Previously tcsetpgrp() would blindly go ahead and set the pgid of the controlling terminal to a negative value, causing later calls to various functions to fail. For example, gdb has code like the following: tcsetpgrp (0, getpgid (inf->pid)); If getpgid (inf->pid) fails (returns -1), then this code would set the pgid of fd 0 to -1, so that some later calls to getpgid() would also return -1. This caused the problem reported here: https://cygwin.com/ml/cygwin/2019-07/msg00166.html.
2019-07-22Cygwin: fix one more check for positive virtual_ftype_t valuesKen Brown2-6/+1
Also drop more comments referring to numerical virtual_ftype_t values.
2019-07-22Cygwin: change virtual_ftype_t to not rely on negative valuesCorinna Vinschen9-36/+31
So far negative values were denoting files, positive values denoting directories. We should prefer a less error prone method. Redefine virtual_ftype_t to contain only positive values and replace checks for negativ or positive values with inline functions virt_ftype_isfile() and virt_ftype_isdir(). Drop outdcated comments referring to numerical virtual_ftype_t values. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2019-07-22Cygwin: fix /proc/PID/fd return value in error caseCorinna Vinschen1-2/+2
commit 2607639992f6 "Improve error handling in /proc/[pid]/ virtual files." changed the return value of the /proc/PID formatting functions to return -1 instead of 0 in the error case to allow a filesize of 0. The patch neglected to change this behaviour for /proc/PID/fd content. This patch fixes that. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2019-07-22Cygwin: add release notes for 3.0.8Ken Brown1-0/+16
2019-07-22Cygwin: socket files are not lnk special filesKen Brown2-3/+5
Change path_conv::is_lnk_special() so that it returns false on socket files. is_lnk_special() is called by rename2() in order to deal with special files (FIFOs and symlinks, for example) whose Win32 names usually have a ".lnk" suffix. Socket files do not fall into this category, and this change prevents ".lnk" from being appended erroneously when such files are renamed. Remove a now redundant !pc.issocket() from fhandler_disk_file::link().
2019-07-22Cygwin: remove path_conv::is_fs_device()Ken Brown1-2/+2
It is used only once.
2019-07-22Cygwin: remove path_conv::is_auto_device()Ken Brown2-2/+1
It is used only once, and the name is supposed to suggest "device that is not based on the filesystem". This intended meaning is clearer if we just replace is_auto_device() by its definition at the place where it's used.
2019-07-22Cygwin: fhandler_*: remove isdevice() and is_auto_device()Ken Brown2-4/+1
isdevice() is used only in the definition of is_auto_device(). And the latter is used only once, in a context where isdevice() always returns true.
2019-07-19Cygwin: unbreak the build with GCC 7Ken Brown2-4/+15
The recent port to GCC 8 used the 'nonstring' attribute, which is unknown to GCC 7. Define and use an 'ATTRIBUTE_NONSTRING' macro instead.
2019-07-17Cygwin: fix GCC 8.3 'asm volatile' errorsKen Brown1-2/+2
Remove the volatile qualifier, which is no longer allowed outside of the function body. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89585 for discussion.
2019-07-16Cygwin: avoid GCC 8.3 errors with -Werror=stringop-truncationKen Brown3-5/+5
2019-07-16Cygwin: avoid GCC 8.3 errors with -Werror=class-memaccessKen Brown4-6/+6
2019-07-12Cygwin: sigpending: don't report pending signals for other threadsCorinna Vinschen2-2/+10
The sigpending mechanism failed to check if the pending signal was a process-wide signal, or a signal for the curent thread. Fix that by adding a matching conditional to wait_sig's __SIGPENDING code. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2019-07-12Cygwin: return full sigset_t from sig_sendCorinna Vinschen5-12/+12
So far sig_send's return type is int. The problem with this is that sig_send returns a sigset_t on __SIGPENDING, and sigset_t is defined as long type. So the function only returns the lower 32 bit of sigset_t, which is fine on 32 bit, but casts away the pending RT signals on 64 bit. Fix this by changing the return type of sig_send to sigset_t, so as not to narrow down the sigset when returning from handling __SIGPENDING. Make sure to cast correctly in all invocations of sig_send. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2019-06-28Cygwin: Fix return value of sched_getaffinityMark Geisert4-11/+31
Have sched_getaffinity() interface like glibc's, and provide an undocumented internal interface __sched_getaffinity_sys() like the Linux kernel's sched_getaffinity() for benefit of taskset(1).
2019-06-27sched: Move Cygwin cpuset definitions into Cygwin-specific headerCorinna Vinschen2-2/+28
This avoids build breakage on RTEMS. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2019-06-27Cygwin: honor the O_PATH flag when opening a FIFOKen Brown1-1/+10
Previously fhandler_fifo::open would treat the FIFO as a reader and would block, waiting for a writer.
2019-06-25Cygwin: FIFO: fix a thinko in raw_writeKen Brown1-1/+0
Remove a line that has no effect.
2019-06-25Tweak release messageKen Brown1-1/+1
2019-06-25Cygwin: timerfd: avoid a deadlockKen Brown3-1/+28
Add a function timerfd_tracker::enter_critical_section_cancelable, which is like enter_critical_section but honors a cancel event. Call this when a timer expires while the timerfd thread is in its inner loop. This avoids a deadlock if timerfd_tracker::dtor has entered its critical section and is trying to cancel the thread. See https://cygwin.com/ml/cygwin/2019-06/msg00096.html.
2019-06-24Cygwin: Implement sched_[gs]etaffinity()Mark Geisert8-5/+356
This patch set implements the Linux syscalls sched_getaffinity, sched_setaffinity, pthread_getaffinity_np, and pthread_setaffinity_np. Linux has a straightforward view of the cpu sets used in affinity masks. They are simply long (1024-bit) bit masks. This code emulates that view while internally dealing with Windows' distribution of available CPUs among processor groups.
2019-06-23Cygwin: FIFO: minor cleanupKen Brown2-7/+7
Don't use a label with the same name as a variable. Also fix indentation in fhandler.h.
2019-06-23Cygwin: FIFO: slightly change the use of write_readyKen Brown1-1/+2
Make it a manual reset event. It's only used once to allow a reader to open, and there's no reason to ever reset it. Defensively set it when a client connection is recorded, even though it should be set by the writer that connected.
2019-06-23Cygwin: FIFO: remove fifo_client_handler::connect_evtKen Brown2-16/+15
It's not needed. Instead just create and use an event in fhandler_fifo::listen_client_thread.
2019-06-23Cygwin: FIFO: simplify raw_readKen Brown1-19/+31
Call NtReadFile directly instead of calling fhandler_base::raw_read. In addition to being simpler, this gives us access to the return value from NtReadFile.
2019-06-23Cygwin: FIFO: improve termination of the listen_client threadKen Brown2-15/+55
Add a method fifo_client_handler::pipe_state that queries Windows for the state of a pipe instance. Use this to help terminate the listen_client thread cleanly. If the last client handler is useless, delete it instead of declaring it invalid.
2019-06-23Cygwin: FIFO: avoid deadlock when closingKen Brown1-0/+3
fhandler_fifo::close could be called from a signal handler or another thread at a time when another function is holding the fifo_client lock. This could prevent the listen_client thread from acting on the thread termination event. Avoid a deadlock by calling fifo_client_unlock at the beginning of fhandler_fifo::close.
2019-06-23Cygwin: FIFO: clean up locksKen Brown1-8/+17
Make sure to use the fifo_client lock when (and only when) it is needed.
2019-06-23Cygwin: FIFO: add some error checkingKen Brown2-4/+11
Change the return type of fhandler_fifo::delete_client_handler from void to int so that we can report errors.
2019-06-23Cygwin: FIFO: fix signal handling in raw_read and raw_writeKen Brown1-31/+54
cygwait wasn't being called correctly. Also do some minor cleanup in raw_read and raw_write.
2019-06-14Rename <xlocale.h> back to <sys/_locale.h>Corinna Vinschen2-1/+4
libX11 provides <X11/Xlocale.h>. The build of libX11 itself adds include/X11 to the compiler's include path. This results in a name collision with /usr/include/xlocale.h on case-insensitive filesystems. Commit 90e35b1eb3df renamed sys/_locale.h to xlocale.h in March 2017 under the assumption that we should provide the locale_t type in the same file as on Linux, FreeBSD, and Darwin. A few weeks later (June 2017), glibc removed the xlocale.h file in favor of bits/types/locale_t.h, which shouldn't be included directly anyway. For reference and the reasoning, see https://sourceware.org/git/?p=glibc.git;a=commit;h=f0be25b6336d Given the above, revert 90e35b1eb3df4070e68afc5e7060665214d586be and fix additional usage of xlocale.h.
2019-06-11Revert "Cygwin: fork: Remember child not before success."Ken Brown1-16/+15
This reverts commit f03ea8e1c57bd5cea83f6cd47fa02870bdfeb1c5. That commit leads to fork problems if cygserver is running: https://cygwin.com/ml/cygwin-patches/2019-q2/msg00155.html
2019-06-05Cygwin: map beyond EOF on 64 bit and WOW64 as wellCorinna Vinschen1-11/+24
32 bit Cygwin performs a POSIX-compatible mapping after EOF which is not supported in this form on Windows. The 64 bit Windows kernel never supported the AT_ROUND_TO_PAGE mapping flag, so we couldn't page-aligned map the space right after the file's EOF. So mapping beyond EOF was disabled in 64 bit Windows and WOW64. However, if mmap works, a matching munmap should work as well, *and* it should not accidentally unmap unrelated memory. Therefore we enable mapping beyond EOF on 64 bit as well. Since that mapping is always 64K aligned, the are between the last file page and the next 64K allocation boundary will be unallocated. There's no way around that. Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2019-06-05mkdir: always check-for-existenceBen Wijen1-1/+3
When using NtCreateFile when creating a directory that already exists, it will correctly return 'STATUS_OBJECT_NAME_COLLISION'. However using this function to create a directory (and all its parents) a normal use would be to start with mkdir(‘/cygdrive/c’) which translates to ‘C:\’ for which it'll instead return ‘STATUS_ACCESS_DENIED’.
2019-06-04Cygwin: Allow accessing 48 bit address space in Windows 8.1 or laterCorinna Vinschen4-5/+20
64 bit Windows started out with a 44 bit address space due to a restriction of the AMD64 CPUs at the time. Starting with Windows 8.1, these CPUs are not supported anymore and Windows switched to the full 48 bit address space supported by AMD64. Cygwin didn't follow suit yet so mmaps are still restricted to the lower 44 bit address space. Fix that by using a system-specific upper address for mmap allocations, 44 bit up to Windows 8, 48 bit starting with Windows 8.1. While at it, move the heap by another 8 Gigs to leave some space for a potential extension of DLL address space, and restrict the mmap lower address so the heap can grow to 32 Gigs before colliding with mmaps.
2019-06-03Cygwin: fork: Remember child not before success.Michael Haubenwallner1-15/+16
Do not remember the child before it was successfully initialized, or we would need more sophisticated cleanup on child initialization failure, like cleaning up the process table and suppressing SIGCHILD delivery with multiple threads ("waitproc") involved. Compared to that, the potential slowdown due to an extra yield () call should be negligible.
2019-06-03Cygwin: fork: Always pause child after fixups.Michael Haubenwallner1-10/+9
Pause the child process after performing fork fixups even if there were no dynamically loaded dlls with extra data/bss transfers to wait for. This allows the parent process to cancel the current fork call even if the child process was successfully initialized already. This is a preparation for when the parent does remember the child no earlier than after successful child initialization.
2019-06-03Cygwin: dll_list: no recursive use of nt_max_path_bufMichael Haubenwallner1-4/+9
Querying the ntlength and existence of the /var/run/cygfork directory in the very first Cygwin process should not use nt_max_path_buf, as that one is used by dll_list::alloc already.
2019-06-03Cygwin: dll_list: stat_real_file_once with ntnameMichael Haubenwallner2-34/+8
NtQueryVirtualMemory for MemorySectionName may return some old path even if the process was just started, for when some directory in between was renamed - maybe because the NT file cache is hot for the old path still. This was seen during gcc bootstrap, returning a MemorySectionName of ".../gcc/xgcc.exe" even if started as ".../prev-gcc/xgcc.exe", where the directory rename from "gcc" to "prev-gcc" was done the moment before. As we stat the module's real file right after loading now, there is no point in using NtQueryVirtualMemory with MemorySectionName any more, and we can use what GetModuleFileName returned instead.
2019-06-03Add support for Hygon Dhyana processorJinke Fan2-2/+4
-Add vendor identification -Support in get_cpu_cache Background: Chengdu Haiguang IC Design Co., Ltd (Hygon) is a Joint Venture between AMD and Haiguang Information Technology Co.,Ltd., aims at providing high performance x86 processor for China server market. Its first generation processor codename is Dhyana, which originates from AMD technology and shares most of the architecture with AMD's family 17h, but with different CPU Vendor ID("HygonGenuine")/Family series number(Family 18h). Related Hygon kernel patch can be found on: http://lkml.kernel.org/r/5ce86123a7b9dad925ac583d88d2f921040e859b.1538583282.git.puwen@hygon.cn Signed-off-by: Jinke Fan <fanjinke@hygon.cn>
2019-05-28Cygwin: FIFO: respect the O_CLOEXEC flagKen Brown1-2/+3
Set the inheritance of the Windows pipe handles according to the O_CLOEXEC flag. Previously the pipe was always created and opened with OBJ_INHERIT.
2019-05-23Cygwin: FIFO: Open only one handle to NPFSKen Brown1-1/+1
Make npfs_handle a static member function of fhandler_fifo, as in fhandler_socket_unix.
2019-05-09Cygwin: FIFO: code simplifications.Ken Brown1-11/+2
There's no longer a need to consider the connect_evt after fork/exec. After stopping the listen_client thread, all client handlers should be in the fc_connected or fc_invalid states, so their connect_evt members won't be used again. Also remove code in fhandler_fifo::dup that just repeats things already done in stop_listen_client.
2019-05-09Cygwin: FIFO: make read_ready an auto-reset eventKen Brown1-1/+1
There's no point in allowing a writer to attempt to open until we've created a pipe instance.
2019-05-09Cygwin: FIFO: improve the check for the listen_client threadKen Brown2-2/+33
Add a method fhandler_fifo::check_listen_client_thread that checks whether the thread is running. Use it in raw_read instead of just testing the handle listen_client_thr.
2019-05-09Cygwin: FIFO: set client handler flags more accuratelyKen Brown1-1/+3
Reflect the fact that client handlers are only used for reading and that, after connection, they are always nonblocking.
generated by cgit v1.1 at 2025-02-01 04:05:18 +0000