aboutsummaryrefslogtreecommitdiff
path: root/newlib/libc
AgeCommit message (Collapse)AuthorFilesLines
9 daysnewlib: libc: return back support for AArch64 ILP32Radek Bartoň14-10/+64
This patch is returning back support for AArch64 ILP32 ABI that was removed in de479a54e22e8fcb6262639a8e67fe8b00a27c37 commit but is needed to ensure source code compatibility with GCC 14. The change in newlib/libc/machine/aarch64/asmdefs.h makes it out-of-the-sync with the current upstream implementation in https://github.com/ARM-software/optimized-routines repository. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
9 daysRevert Joel's working ilp32 patchJoel Sherrill16-108/+54
This was what I was using locally before Radek Bartoň <radek.barton@microsoft.com> had his version of the patch. Revert in favor of his final version. Revert 70c5505766ad4ae62e4d045835ed2a6b928d5760
9 daysilp32: Revert patch removing ilp32 supportJoel Sherrill16-54/+108
ilp32 support was removed prematurely. It is still in GCC 15 which is the latest GCC release. From: <radek.barton@microsoft.com> Date: Thu, 5 Jun 2025 11:32:08 +0200 Subject: [PATCH] newlib: libc: update asmdefs.h compatible with Cygwin AArch64 This patch synchronizes newlib/libc/machine/aarch64/asmdefs.h header with version from https://github.com/ARM-software/optimized-routines/commit/4352245388a55a836f3ac9ac5907022c24ab8e4c commit that added support for AArch64 Cygwin. This version of the header removed PTR_ARG and SIZE_ARG macros as ILP32 was deprecated which introduced changes in many .S files so the patch contains removal of usages of those macros. On top of that, setjmp.S and rawmemchr.S were refactored to use ENTRY/ENTRY_ALIGN and END macros. ` Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
11 daysRevert "mbrtowc: fix handling invalid UTF-8 4 byte sequences if wchar_t == ↵Corinna Vinschen1-16/+9
UTF-16" This reverts commit b374973d14ac7969b10ba719feedc709f6971c0d. Turns out this patch breaks mbrtowc. Example: --- SNIP --- void mb(unsigned char c) {   wchar_t wc;   int ret = mbrtowc(&wc, &c, 1, 0);   printf("%02X -> %04X : %d\n", c, wc, ret); } void main () {   setlocale (LC_CTYPE, "");   mb(0xF0);   mb(0x9F);   mb(0x98);   mb(0x8E); } --- SNAP --- Output before commit b374973d14ac: F0 -> 0000 : -2 9F -> 0000 : -2 98 -> D83D : 1 8E -> DE0E : 1 Output after commit b374973d14ac: F0 -> 0000 : -2 9F -> 0000 : -2 98 -> 0000 : -2 8E -> D83D : 3 By using mbrtowc(), the high surrogate is only emitted after byte 4, and there's no way to recover the low surrogate. The byte count is also incorrect. Conclusion: We have to emit the high surrogate already after byte 3 to be able to emit the low surrogate after byte 4. Reported-by: Thomas Wolff <towo@towo.net> Addresses: https://cygwin.com/pipermail/cygwin/2025-July/258513.html Fixes: b374973d14ac ("mbrtowc: fix handling invalid UTF-8 4 byte sequences if wchar_t == UTF-16") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
12 dayssys/cdefs.h: Protect parameters to __builtin_is_aligned()Paul Cercueil1-1/+1
The macro was not protecting properly its first parameter, which caused it to silently return an invalid value when passing a composed parameter, ie. __builtin_is_aligned(src | dst | len, 32); Signed-off-by: Paul Cercueil <paul@crapouillou.net>
12 daysReapply "libc/stdio: Remove wchar_t functions from NEWLIB_NANO_FORMATTED_IO"Corinna Vinschen1-26/+26
This reverts commit bb2c338520b9da9fd3ac067438e9aeeffc0b122a. Accidental push.
12 daysRevert "libc/stdio: Remove wchar_t functions from NEWLIB_NANO_FORMATTED_IO"Hau Hsu1-26/+26
This reverts commit 3b97a5ec67a5a52c130158bb143949cd842de305.
14 daysnewlib: add dummy implementations of fe{get,set}prec for Aarch64 CygwinRadek Bartoň1-0/+15
This patch introduces dummy implementation of fegetprec and fsetprec for Cygwin build as those symbols are being exported by cygwin1.dll and AArch64 do not support changing floating point precision at runtime. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-17libc/include/sys/stat.h: Adjust for RTEMS MIPSJoel Sherrill1-2/+3
The commit cited below introduced changes which included conditionals strictly on __mips__. This ignored tailoring for any environment on MIPS except that targeted by the author of the change. This patch just fixes this code for RTEMS. commit 467a2bdf17ad376dafada9f1734784f4611fa6fd Author: Jovan Dmitrović <jovan.dmitrovic@htecgroup.com> Date: Wed Jun 11 10:11:33 2025 +0200 mips: Implement MIPS HAL and UHI Implement abstract interface for MIPS, including unified hosting interface (UHI). Signed-off-by: Jovan Dmitrović <jovan.dmitrovic@htecgroup.com>
2025-07-17nvptx: Change 'read' and 'write' to 'ssize_t' return typeArijit Kumar Das3-2/+8
This commit changes the return type of the read() and write() syscalls for nvptx to ssize_t. This would allow large files to be handled properly by these syscalls in situations where the read/write buffer length exceeds INT_MAX, for example. This also makes the syscall signatures fully complaint with their current POSIX specifications. We additionally define two macros: '_READ_WRITE_RETURN_TYPE' as _ssize_t and '_READ_WRITE_BUFSIZE_TYPE' as __size_t in libc/include/sys/config.h under __nvptx__ for consistency. Signed-off-by: Arijit Kumar Das <arijitkdgit.official@gmail.com>
2025-07-17newlib: libc: update asmdefs.h compatible with Cygwin AArch64Radek Bartoň16-108/+54
This patch synchronizes newlib/libc/machine/aarch64/asmdefs.h header with version from https://github.com/ARM-software/optimized-routines/commit/4352245388a55a836f3ac9ac5907022c24ab8e4c commit that added support for AArch64 Cygwin. This version of the header removed PTR_ARG and SIZE_ARG macros as ILP32 was deprecated which introduced changes in many .S files so the patch contains removal of usages of those macros. On top of that, setjmp.S and rawmemchr.S were refactored to use ENTRY/ENTRY_ALIGN and END macros. ` Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-17newlib: fclose: Use sfp lock while fp lock is activeTakashi Yano1-1/+2
With the commit 656df313e08a, if a thread acquires sfp lock after another thread calls fclose() and fp lock is acquired, the first thread falls into deadlock if it tries to acquire fp lock. This can happen if the first thread calls __sfp_lock_all() while the second thread calls fclose(). This patch reverts the changes for newlib/libc/stdio/fclose.c in the commit 656df313e08a. Addresses: https://cygwin.com/pipermail/cygwin/2025-June/258323.html Fixes: 656df313e08a ("* libc/stdio/fclose.c: Only use sfp lock to guard non-atomic changes of flags and fp lock.") Reported-by: Takashi Yano <takashi.yano@nifty.ne.jp> Reviewed-by: Corinna Vinschen <corinna@vinschen.de> Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
2025-07-16libc/time: Add CLOCK_TAISebastian Huber1-0/+6
For _GNU_VISIBLE, provide the CLOCK_TAI clock identifier for the International Atomic Time. Use the value specified by glibc and Linux. Add _BSD_VISIBLE given FreeBSD also provides this clock identifier.
2025-07-10RISC-V: memmove() speed optimized: Call memcpy()m fally1-67/+93
Redirect to memcpy() if the memory areas of source and destination do not overlap. Only redirect if length is > SZREG in order to reduce overhead on very short copies. Signed-off-by: m fally <marlene.fally@gmail.com>
2025-07-10RISC-V: memmove() speed optimized: Align source addressm fally1-50/+135
If misaligned accesses are slow or prohibited, either source or destination address are unaligned and the number of bytes to be copied is > SZREG*2, align the source address to xlen. This speeds up the function in the case where at least one address is unaligned, since now one word (or doubleword for rv64) is loaded at a time, therefore reducing the amount of memory accesses necessary. We still need to store back individual bytes since the destination address might (still) be unaligned after aligning the source. The threshold of SZREG*2 was chosen to keep the negative effect on shorter copies caused by the additional overhead from aligning the source low. This change also affects the case where both adresses are xlen- aligned, the memory areas overlap destructively, and length is not a multiple of SZREG. In the destructive-overlap case, the copying needs to be done in reversed order. Therefore the length is added to the addresses first, which causes them to become unaligned. Reviewed-by: Christian Herber <christian.herber@oss.nxp.com> Signed-off-by: m fally <marlene.fally@gmail.com>
2025-07-10RISC-V: memmove() speed optimized: Add loop-unrollingm fally1-9/+48
Add loop-unrolling for the case where both source and destination address are aligned in the case of a destructive overlap, and increase the unroll factor from 4 to 9 for the word-by-word copy loop in the non-destructive case. This matches the loop-unrolling done in memcpy() and increases performance for lenghts >= SZREG*9 while almost not at all degrading performance for shorter lengths. Reviewed-by: Christian Herber <christian.herber@oss.nxp.com> Signed-off-by: m fally <marlene.fally@gmail.com>
2025-07-10RISC-V: memmove() speed optimized: Replace macros and use fixed-width typesm fally1-25/+35
Replace macros with static inline functions or RISC-V specifc macros in order to keep consistency between all functions in the port. Change data types to fixed-width and/or RISC-V specific types. Reviewed-by: Christian Herber <christian.herber@oss.nxp.com> Signed-off-by: m fally <marlene.fally@gmail.com>
2025-07-10RISC-V: memmove() speed optimized: Add implementationm fally4-15/+100
Copy the common implementation of memmove() to the RISC-V port. Rename memmove.S to memmove-asm.S to keep naming of files consistent between functions. Update Makefile.inc with the changed filenames. Reviewed-by: Christian Herber <christian.herber@oss.nxp.com> Signed-off-by: m fally <marlene.fally@gmail.com>
2025-07-09posix_spawn: preserve FD flags when processing FAE_OPENJeremy Drake1-3/+11
According to the POSIX documentation, "when the new process image is executed, any file descriptor (from this new set) which has its FD_CLOEXEC flag set shall be closed (see posix_spawn())." The "new set" is after processing the file actions, so if addopen had the O_CLOEXEC flag set the descriptor should be closed after the exec. The adddup2 docs, by contrast, specify that the flag should be cleared, even if dup2 wouldn't have done so due to the specified file descriptors being equal. Add a comment to that effect. Addresses: https://sourceware.org/pipermail/newlib/2025/021968.html Fixes: c7c1a1ca1b ("2013-10-01 Petr Hosek <phosek@chromium.org>") Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
2025-07-04libc: mips: fix strcmp bug for little endian targetsFaraz Shahbazker1-2/+5
strcmp gives incorrect result for little endian targets under the following conditions: 1. Length of 1st string is 1 less than a multiple of 4 (i.e len%4=3) 2. First string is a prefix of the second string 3. The first differing character in the second string is extended ASCII (that is > 127) Signed-off-by: Jovan Dmitrović <jovan.dmitrovic@htecgroup.com>
2025-07-04libc: mips: Improve performance of strcmp implementationFaraz Shahbazker1-79/+123
Improve `strcmp` by using `ext` instruction, if available. Signed-off-by: Jovan Dmitrović <jovan.dmitrovic@htecgroup.com>
2025-07-04libc: mips: memcpy prefetches beyond copied memoryFaraz Shahbazker1-53/+97
Fix prefetching in core loop to avoid exceeding the operated upon memory region. Revert accidentally changed prefetch-hint back to streaming mode. Refactor various bits and provide pre-processor checks to allow parameters to be overridden from compiler command line. Signed-off-by: Jovan Dmitrović <jovan.dmitrovic@htecgroup.com>
2025-07-04libc: mips: Add improved C implementation of memcpy/memsetFaraz Shahbazker3-1/+582
Signed-off-by: Jovan Dmitrović <jovan.dmitrovic@htecgroup.com>
2025-07-04mips: Implement MIPS HAL and UHIJovan Dmitrović7-121/+157
Implement abstract interface for MIPS, including unified hosting interface (UHI). Signed-off-by: Jovan Dmitrović <jovan.dmitrovic@htecgroup.com>
2025-07-04aarch64: Export fe{enable,disable,get}except on CygwinRadek Bartoň1-4/+12
For aarch64 on ELF targets, the library does not export fe{enable,disable,get}except as symbols from the library, relying on static inline functions to provide suitable definitions if required. But for Cygwin we need to create real definitions to satisfy the DLL export script. So arrange for real definitions of these functions when building on Cygwin. Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-02wcstombs: also call __WCTOMB on terminating NUL if output buffer is NULLChristian Franke1-3/+4
A __WCTOMB call on the terminating NUL may emit more than a NUL byte. This is the case if the string ends with a lone UTF-16 high surrogate. Fixes: 2a3a02a68764 ("Add SUSV2 support for calculating size if output buffer is NULL") Signed-off-by: Christian Franke <christian.franke@t-online.de>
2025-07-02newlib: increase jump buffer length to 25 to fit all non-volatile registers ↵Radek Bartoň1-1/+10
for aarch64-pc-cygwin Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-07-02RISC-V: Fix memcpy() for GCC 13Sebastian Huber1-2/+2
GCC 13 does not define the __riscv_misaligned_* builtin defines. They are supported by GCC 14 or later. Test for __riscv_misaligned_fast to select an always correct memcpy() implementation for GCC 13. Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
2025-06-29wcrtomb: fix CESU-8 value of leftover lone high surrogateChristian Franke1-2/+2
Addresses: https://cygwin.com/pipermail/cygwin/2025-June/258378.html Fixes: 6ff28fc3b121 ("Allow CESU-8 surrogate value encoding") Signed-off-by: Christian Franke <christian.franke@t-online.de>
2025-06-27mbrtowc: fix handling invalid UTF-8 4 byte sequences if wchar_t == UTF-16Corinna Vinschen1-9/+16
When commit 28186e81d947 split _mbtowc_r into per-codeset functions, the code generating wchar_t from UTF-8 input was slightly rearranged. Unfortunately the new code introduced a bug: On systems with wchar_t being UTF-16, 4 byte sequences have to be converted to surrogate pairs. The low surrogate pair can be fully created from the first 3 bytes of the sequence. However, the surrogates should only be created if it's clear that the 4th byte is valid, and the entire 4 byte string represents a valid UTF-8 sequence. The code change in 28186e81d947 neglected just that: In contrast to the original code, it now created the low surrogate after having read the first 3 bytes of the sequence, without checking validity of the 4th byte. This patch moves the test sequence to check the 4th byte in front of the code generating the low surrogate. Make sure to return the value 3 (3 bytes digested) rather than the content of the local variable i, which is already set to 4 at this point. Reported-by: Christian Franke <Christian.Franke@t-online.de> Addresses: https://cygwin.com/pipermail/cygwin/2025-June/258358.html Fixes: 28186e81d947 ("* libc/ctype/iswalpha.c: Handle all wchar_t as unicode on _MB_CAPABLE systems.") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2025-06-24libc: Update the guard for quick_exit() and at_quick_exit() functionsMazen Adel Elmessady1-1/+4
Updated the guard for stdlib functions to use the POSIX Issue 8 guard added in 2024.
2025-06-24libc: Added the prototype for ppoll()Mazen Adel Elmessady1-0/+9
Added prototype of ppoll() to newlib/libc/sys/rtems/include/sys/poll.h
2025-06-24libc: Added the prototype for sem_clockwait()Mazen Adel Elmessady1-0/+6
Added the prototype for sem_clockwait() to newlib/libc/sys/rtems/include/semaphore.h
2025-06-24libc/../pthread.h: Updated the guard for Posix Issue 8 functionsMazen Adel Elmessady1-6/+6
Updated the guard for pthread functions added in POSIX Issue 8 to use the POSIX Issue 8 guard added in 2024. These functions are: pthread_mutex_clocklock() pthread_cond_clockwait() pthread_rwlock_clockrdlock() pthread_rwlock_clockwrlock()
2025-06-24libc: Added timespec_get() to time.hMazen Adel Elmessady1-0/+5
Added timespec_get() prototype to libc/include/time.h and removed the prototype from winsup/cygwin/include/cygwin/time.h
2025-06-18add value for _h_errno in _REENT_INIT(var) for struct, _reentJohannes Rosa1-1/+2
The define '_REENT_INIT' for the case '!_REENT_SMALL' was missing an initializing value for 'int _h_errno'. If code uses the _REENT_INIT() macro to preset a variable of type struct _reent, this led to an issue when compiling with -Wmissing-field-initializers.
2025-06-18posix_spawn: factor out structs to an internal headerJeremy Drake2-44/+55
This will allow Cygwin to examine and handle the posix_spawnattr_t and posix_spawn_file_actions_t arguments itself. Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
2025-06-18newlib: libc: define _ctype for AArch64 CygwinRadek Bartoň1-9/+0
Signed-off-by: Radek Bartoň <radek.barton@microsoft.com>
2025-06-14rtems/include/limits.h: Do not define AIO_LISTIO_MAX or AIO_MAXJoel Sherrill1-4/+6
Per https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/limits.h.html, these limits.h constants should not be defined if the implementation does not have an inherent limit. These are based on available memory for RTEMS.
2025-06-14rtems/../sys/dirent.h: Enable DT_ symbols for POSIX >= 202405LJoel Sherrill1-1/+1
Issue 8 added these symbols which which previously BSD extensions.
2025-06-02RISC-V: strcmp [speed optimized]: optimize mismatch logic for targets with ↵puranikvinit1-63/+94
Zb* extension support Reworks the mismatch handling to use Zbb's ctz/clz instructions for faster byte difference detection, significantly improving performance on Zbb-capable targets. Non-Zbb targets retain the original logic for compatibility. Signed-off-by: puranikvinit <kvp933.vinit@gmail.com> Reviewed-by: Christian Herber <christian.herber@oss.nxp.com>
2025-06-02RISC-V: strcmp [speed optimized]: optimize null detect logic for targets ↵puranikvinit1-4/+8
with Zb* extension support Introduces conditional use of the orc.b instruction from the Zbb extension for null byte detection, falling back to the original logic for non-Zbb targets. This reduces cycles in the hot path for supported architectures. Signed-off-by: puranikvinit <kvp933.vinit@gmail.com> Reviewed-by: Christian Herber <christian.herber@oss.nxp.com>
2025-06-02RISC-V: strcmp [speed optimized]: use compressed registers wherever possiblepuranikvinit1-4/+4
Replaces temporary registers (t0) with compressed registers (a4) in the null detection loop, reducing instruction count and code size in speed-optimized builds while maintaining identical logic. Signed-off-by: puranikvinit <kvp933.vinit@gmail.com> Reviewed-by: Christian Herber <christian.herber@oss.nxp.com>
2025-06-02RISC-V: strcmp: refactor labels for improved readabilitypuranikvinit1-13/+18
Renames labels in strcmp.S to use descriptive .L prefixes (e.g., .Lcompare, .Lreturn_diff) instead of numeric labels (e.g., 1f, 2f). This improves maintainability and aligns with modern assembly conventions without affecting functionality. Signed-off-by: puranikvinit <kvp933.vinit@gmail.com> Reviewed-by: Christian Herber <christian.herber@oss.nxp.com>
2025-06-02RISC-V: setjmp: reduce code size for register load/store with Zilsdpuranikvinit1-25/+49
This patch optimizes the RISC-V setjmp implementation in newlib/libc/machine/riscv/setjmp.S for 32-bit targets. It reduces code size by using doubleword store/load instructions (sd/ld) when the Zilsd or Zclsd extensions are available for saving and restoring s0-s11 registers, while preserving the original single-word instructions (REG_S/REG_L) for compatibility with other configurations. Signed-off-by: puranikvinit <kvp933.vinit@gmail.com> Reviewed-by: Christian Herber <christian.herber@oss.nxp.com> RISC-V: setjmp: reduce code size for register load/store with Zilsd
2025-06-02newlib: riscv: Remove undefined behavior in strlen()Eric Salem1-1/+4
Pointer arithmetic overflow is undefined behavior, so use a signed type to avoid it. Signed-off-by: Eric Salem <ericsalem@gmail.com>
2025-05-28newlib: riscv: Align whitespace of size optimized memset()Eric Salem1-4/+4
Align the whitespace of the size optimized implementation of memset() to match the speed optimized version. Reviewed-by: Christian Herber <christian.herber@oss.nxp.com> Signed-off-by: Eric Salem <ericsalem@gmail.com>
2025-05-28newlib: riscv: Optimize memset() for speedEric Salem1-71/+262
The RISC-V Zba, Zbkb, and Zilsd/Zclsd extensions provide instructions optimized for bit and load/store operations. Use them when available for the RISC-V port. Also increase loop unrolling for faster performance. Reviewed-by: Christian Herber <christian.herber@oss.nxp.com> Signed-off-by: Eric Salem <ericsalem@gmail.com>
2025-05-27RISC-V: memcpy() align dest when misaligned access is prohibitedMahmoud Abumandour1-12/+60
Add a code path for when source and dest are differently aligned. If misaligned access is slow or prohibited, and the alignments of the source and destination are different, we align the destination to do XLEN stores. This uses only one aligned store for every four (or eight for XLEN == 64) bytes of data. Reviewed-by: Christian Herber <christian.herber@oss.nxp.com> Signed-off-by: Mahmoud Abumandour <ma.mandourr@gmail.com>
2025-05-27RISC-V: memcpy() Use inline functions instead of macros and gotosMahmoud Abumandour1-18/+24
Reviewed-by: Christian Herber <christian.herber@oss.nxp.com> Signed-off-by: Mahmoud Abumandour <ma.mandourr@gmail.com>