aboutsummaryrefslogtreecommitdiff
path: root/winsup
diff options
context:
space:
mode:
authorCorinna Vinschen <corinna@vinschen.de>2005-01-06 17:43:55 +0000
committerCorinna Vinschen <corinna@vinschen.de>2005-01-06 17:43:55 +0000
commit375c7faa4c9da784454ca42302ca7d59bb2c8f77 (patch)
treef5c92defde42386de9a9d5901f64c4ea61aab388 /winsup
parente66b2c9522691757c2349ce581e9116c8f6fdca4 (diff)
downloadnewlib-375c7faa4c9da784454ca42302ca7d59bb2c8f77.zip
newlib-375c7faa4c9da784454ca42302ca7d59bb2c8f77.tar.gz
newlib-375c7faa4c9da784454ca42302ca7d59bb2c8f77.tar.bz2
* fhandler_disk_file.cc (fhandler_base::open_fs): Don't allow
opening directories for writing.
Diffstat (limited to 'winsup')
-rw-r--r--winsup/cygwin/ChangeLog5
-rw-r--r--winsup/cygwin/fhandler_disk_file.cc8
2 files changed, 13 insertions, 0 deletions
diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog
index 0dee5fc..464e57d 100644
--- a/winsup/cygwin/ChangeLog
+++ b/winsup/cygwin/ChangeLog
@@ -1,3 +1,8 @@
+2005-01-06 Corinna Vinschen <corinna@vinschen.de>
+
+ * fhandler_disk_file.cc (fhandler_base::open_fs): Don't allow
+ opening directories for writing.
+
2005-01-06 Christopher Faylor <cgf@timesys.com>
* timer.cc (timer_thread): Pass sigev pointer value as per SuSv3 rather
diff --git a/winsup/cygwin/fhandler_disk_file.cc b/winsup/cygwin/fhandler_disk_file.cc
index 7fc6a14..1901d17 100644
--- a/winsup/cygwin/fhandler_disk_file.cc
+++ b/winsup/cygwin/fhandler_disk_file.cc
@@ -568,6 +568,14 @@ fhandler_base::open_fs (int flags, mode_t mode)
return 0;
}
+ /* Unfortunately NT allows to open directories for writing, but that's
+ disallowed according to SUSv3. */
+ if (pc.isdir () && (flags & (O_WRONLY | O_RDWR)))
+ {
+ set_errno (EISDIR);
+ return 0;
+ }
+
int res = fhandler_base::open (flags | O_DIROPEN, mode);
if (!res)
goto out;