diff options
| author | Takashi Yano <takashi.yano@nifty.ne.jp> | 2024-02-13 11:17:46 +0900 |
|---|---|---|
| committer | Takashi Yano <takashi.yano@nifty.ne.jp> | 2024-02-13 23:23:52 +0900 |
| commit | 06992ed6b4c63c6e77052fdc9359ce003fc3409f (patch) | |
| tree | 7024385620bf6a1f50622e308be4991d51030418 /winsup/cygwin | |
| parent | 10c8c1cf4f94ed42c59015d7e972269724c451bf (diff) | |
| download | newlib-06992ed6b4c63c6e77052fdc9359ce003fc3409f.zip newlib-06992ed6b4c63c6e77052fdc9359ce003fc3409f.tar.gz newlib-06992ed6b4c63c6e77052fdc9359ce003fc3409f.tar.bz2 | |
Cygwin: pty: Fix handle leak in master process.
If non-cygwin process is started in pty, closing from_master_nat
pipe handle was missing in fhandler_pty_slave::input_transfer().
This occured because the handle was duplicated but not closed.
https://github.com/msys2/msys2-runtime/issues/198
Fixes: 29431fcb5b14 ("Cygwin: pty: Inherit typeahead data between two input pipes.")
Reported-by: Hakkin Lain
Signed-off-by: Takashi Yano <takashi.yano@nifty.ne.jp>
Diffstat (limited to 'winsup/cygwin')
| -rw-r--r-- | winsup/cygwin/fhandler/pty.cc | 1 | ||||
| -rw-r--r-- | winsup/cygwin/release/3.5.1 | 4 |
2 files changed, 5 insertions, 0 deletions
diff --git a/winsup/cygwin/fhandler/pty.cc b/winsup/cygwin/fhandler/pty.cc index 3f4bc56..c5c7921 100644 --- a/winsup/cygwin/fhandler/pty.cc +++ b/winsup/cygwin/fhandler/pty.cc @@ -3995,6 +3995,7 @@ fhandler_pty_slave::transfer_input (tty::xfer_dir dir, HANDLE from, tty *ttyp, transfered = true;; } } + CloseHandle (to); /* Fix input_available_event which indicates availability in cyg pipe. */ if (dir == tty::to_nat) /* all data is transfered to nat pipe, diff --git a/winsup/cygwin/release/3.5.1 b/winsup/cygwin/release/3.5.1 index 81945db..715fcf7 100644 --- a/winsup/cygwin/release/3.5.1 +++ b/winsup/cygwin/release/3.5.1 @@ -12,3 +12,7 @@ Fixes: error mode is now possible by using the new CYGWIN environment variable option "winjitdebug". Addresses: https://cygwin.com/pipermail/cygwin/2024-February/255305.html + +- Fix handle leak in pty master which occurs when non-cygwin process + is started in pty. + Addresses: https://github.com/msys2/msys2-runtime/issues/198 |