aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCorinna Vinschen <corinna@vinschen.de>2025-01-15 11:22:38 +0100
committerCorinna Vinschen <corinna@vinschen.de>2025-01-15 12:27:03 +0100
commita238211828b59c9cb8f0851dc74ce59598dda337 (patch)
treec69681608076fd779ff37d25e7e069832e151043
parent97c3835a0301dba7148348d1569151cf00deb617 (diff)
downloadnewlib-a238211828b59c9cb8f0851dc74ce59598dda337.zip
newlib-a238211828b59c9cb8f0851dc74ce59598dda337.tar.gz
newlib-a238211828b59c9cb8f0851dc74ce59598dda337.tar.bz2
Cygwin: get_posix_access: don't drop admin and system perms in default ACL
The permissions of entries for SYSTEM and the Administrators group are not added to the CLASS_OBJ entry, so they don't set the class perms to rwx all the time. This shouldn't be done for default perms, otherwise the resulting permissions when generating new files might be surprisingly restricted for Admins and SYSTEM. Fixes: bc444e5aa4ca ("Reapply POSIX ACL changes.") Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
-rw-r--r--winsup/cygwin/sec/acl.cc5
1 files changed, 0 insertions, 5 deletions
diff --git a/winsup/cygwin/sec/acl.cc b/winsup/cygwin/sec/acl.cc
index a73fae3..d68bebf 100644
--- a/winsup/cygwin/sec/acl.cc
+++ b/winsup/cygwin/sec/acl.cc
@@ -995,11 +995,6 @@ get_posix_access (PSECURITY_DESCRIPTOR psd,
if (type & (USER | GROUP))
{
has_def_class_perm = true;
- /* Accommodate Windows: Never add SYSTEM and Admins to
- CLASS_OBJ. Unless (implicitly) if they are the
- GROUP_OBJ entry. */
- if (ace_sid != well_known_system_sid
- && ace_sid != well_known_admins_sid)
def_class_perm |= lacl[pos].a_perm;
}
/* And note the position of the DEF_GROUP_OBJ entry. */