* path.cc (suffix_scan::has): Reorganize to eliminate double scanning for forgithub/unlabeled-1.226.2unlabeled-1.226.2

.exe (in the typical case).
* fhandler_socket.cc (fhandler_socket::set_sun_path): Don't free memory here.
Allow NULL parameter.
* fhandler_socket.cc (fhandler_socket::dup): Add missing copy operation on
sun_path.

1 files changed, 36 insertions, 34 deletions

diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
index ed76f94..c09b459 100644
--- a/winsup/cygwin/path.cc
+++ b/winsup/cygwin/path.cc
@@ -2822,8 +2822,43 @@ suffix_scan::has (const char *in_path, const suffix_info *in_suffixes)
 int
 suffix_scan::next ()
 {
-  if (suffixes)
+  for (;;)
     {
+      if (!suffixes)
+	switch (nextstate)
+	  {
+	  case SCAN_BEG:
+	    suffixes = suffixes_start;
+	    if (!suffixes)
+	      {
+		nextstate = SCAN_LNK;
+		return 1;
+	      }
+	    if (!*suffixes->name)
+	      suffixes++;
+	    nextstate = SCAN_EXTRALNK;
+	    /* fall through to suffix checking below */
+	    break;
+	  case SCAN_HASLNK:
+	    nextstate = SCAN_EXTRALNK;	/* Skip SCAN_BEG */
+	    return 1;
+	  case SCAN_LNK:
+	  case SCAN_EXTRALNK:
+	    strcpy (eopath, ".lnk");
+	    nextstate = SCAN_DONE;
+	    return 1;
+	  case SCAN_JUSTCHECK:
+	    nextstate = SCAN_APPENDLNK;
+	    return 1;
+	  case SCAN_APPENDLNK:
+	    strcat (eopath, ".lnk");
+	    nextstate = SCAN_DONE;
+	    return 1;
+	  default:
+	    *eopath = '\0';
+	    return 0;
+	  }
+
       while (suffixes && suffixes->name)
 	if (!suffixes->addon)
 	  suffixes++;
@@ -2837,39 +2872,6 @@ suffix_scan::next ()
 	  }
       suffixes = NULL;
     }
-
-  switch (nextstate)
-    {
-    case SCAN_BEG:
-      suffixes = suffixes_start;
-      if (!suffixes)
-	nextstate = SCAN_LNK;
-      else
-	{
-	  if (!*suffixes->name)
-	    suffixes++;
-	  nextstate = SCAN_EXTRALNK;
-	}
-      return 1;
-    case SCAN_HASLNK:
-      nextstate = SCAN_EXTRALNK;	/* Skip SCAN_BEG */
-      return 1;
-    case SCAN_LNK:
-    case SCAN_EXTRALNK:
-      strcpy (eopath, ".lnk");
-      nextstate = SCAN_DONE;
-      return 1;
-    case SCAN_JUSTCHECK:
-      nextstate = SCAN_APPENDLNK;
-      return 1;
-    case SCAN_APPENDLNK:
-      strcat (eopath, ".lnk");
-      nextstate = SCAN_DONE;
-      return 1;
-    default:
-      *eopath = '\0';
-      return 0;
-    }
 }
 
 /* Check if PATH is a symlink.  PATH must be a valid Win32 path name.