1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
|
//===- Remarks.cpp - MLIR Remarks -----------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "mlir/IR/Remarks.h"
#include "mlir/IR/BuiltinAttributes.h"
#include "mlir/IR/Diagnostics.h"
#include "mlir/IR/Value.h"
#include "llvm/ADT/StringExtras.h"
#include "llvm/ADT/StringRef.h"
using namespace mlir::remark::detail;
//------------------------------------------------------------------------------
// Remark
//------------------------------------------------------------------------------
Remark::Arg::Arg(llvm::StringRef k, Value v) : key(k) {
llvm::raw_string_ostream os(val);
os << v;
}
Remark::Arg::Arg(llvm::StringRef k, Type t) : key(k) {
llvm::raw_string_ostream os(val);
os << t;
}
void Remark::insert(llvm::StringRef s) { args.emplace_back(s); }
void Remark::insert(Arg a) { args.push_back(std::move(a)); }
// Simple helper to print key=val list (sorted).
static void printArgs(llvm::raw_ostream &os, llvm::ArrayRef<Remark::Arg> args) {
if (args.empty())
return;
llvm::SmallVector<Remark::Arg, 8> sorted(args.begin(), args.end());
llvm::sort(sorted, [](const Remark::Arg &a, const Remark::Arg &b) {
return a.key < b.key;
});
for (size_t i = 0; i < sorted.size(); ++i) {
const auto &a = sorted[i];
os << a.key << "=";
llvm::StringRef val(a.val);
bool needsQuote = val.contains(' ') || val.contains(',') ||
val.contains('{') || val.contains('}');
if (needsQuote)
os << '"' << val << '"';
else
os << val;
if (i + 1 < sorted.size())
os << ", ";
}
}
/// Print the remark to the given output stream.
/// Example output:
// clang-format off
/// [Missed] Category: Loop | Pass:Unroller | Function=main | Reason="tripCount=4 < threshold=256"
/// [Failure] LoopOptimizer | Reason="failed due to unsupported pattern"
// clang-format on
void Remark::print(llvm::raw_ostream &os, bool printLocation) const {
// Header: [Type] pass:remarkName
StringRef type = getRemarkTypeString();
StringRef categoryName = getFullCategoryName();
StringRef name = remarkName;
os << '[' << type << "] ";
os << name << " | ";
if (!categoryName.empty())
os << "Category:" << categoryName << " | ";
if (!functionName.empty())
os << "Function=" << getFunction() << " | ";
if (printLocation) {
if (auto flc = mlir::dyn_cast<mlir::FileLineColLoc>(getLocation()))
os << " @" << flc.getFilename() << ":" << flc.getLine() << ":"
<< flc.getColumn();
}
printArgs(os, getArgs());
}
std::string Remark::getMsg() const {
std::string s;
llvm::raw_string_ostream os(s);
print(os);
os.flush();
return s;
}
llvm::StringRef Remark::getRemarkTypeString() const {
switch (remarkKind) {
case RemarkKind::RemarkUnknown:
return "Unknown";
case RemarkKind::RemarkPassed:
return "Passed";
case RemarkKind::RemarkMissed:
return "Missed";
case RemarkKind::RemarkFailure:
return "Failure";
case RemarkKind::RemarkAnalysis:
return "Analysis";
}
llvm_unreachable("Unknown remark kind");
}
llvm::remarks::Type Remark::getRemarkType() const {
switch (remarkKind) {
case RemarkKind::RemarkUnknown:
return llvm::remarks::Type::Unknown;
case RemarkKind::RemarkPassed:
return llvm::remarks::Type::Passed;
case RemarkKind::RemarkMissed:
return llvm::remarks::Type::Missed;
case RemarkKind::RemarkFailure:
return llvm::remarks::Type::Failure;
case RemarkKind::RemarkAnalysis:
return llvm::remarks::Type::Analysis;
}
llvm_unreachable("Unknown remark kind");
}
llvm::remarks::Remark Remark::generateRemark() const {
auto locLambda = [&]() -> llvm::remarks::RemarkLocation {
if (auto flc = dyn_cast<FileLineColLoc>(getLocation()))
return {flc.getFilename(), flc.getLine(), flc.getColumn()};
return {"<unknown file>", 0, 0};
};
llvm::remarks::Remark r; // The result.
r.RemarkType = getRemarkType();
r.RemarkName = getRemarkName();
// MLIR does not use passes; instead, it has categories and sub-categories.
r.PassName = getFullCategoryName();
r.FunctionName = getFunction();
r.Loc = locLambda();
for (const Remark::Arg &arg : getArgs()) {
r.Args.emplace_back();
r.Args.back().Key = arg.key;
r.Args.back().Val = arg.val;
}
return r;
}
//===----------------------------------------------------------------------===//
// InFlightRemark
//===----------------------------------------------------------------------===//
InFlightRemark::~InFlightRemark() {
if (remark && owner)
owner->report(std::move(*remark));
owner = nullptr;
}
//===----------------------------------------------------------------------===//
// Remark Engine
//===----------------------------------------------------------------------===//
template <typename RemarkT, typename... Args>
InFlightRemark RemarkEngine::makeRemark(Args &&...args) {
static_assert(std::is_base_of_v<Remark, RemarkT>,
"RemarkT must derive from Remark");
return InFlightRemark(*this,
std::make_unique<RemarkT>(std::forward<Args>(args)...));
}
template <typename RemarkT>
InFlightRemark
RemarkEngine::emitIfEnabled(Location loc, RemarkOpts opts,
bool (RemarkEngine::*isEnabled)(StringRef) const) {
return (this->*isEnabled)(opts.categoryName) ? makeRemark<RemarkT>(loc, opts)
: InFlightRemark{};
}
bool RemarkEngine::isMissedOptRemarkEnabled(StringRef categoryName) const {
return missFilter && missFilter->match(categoryName);
}
bool RemarkEngine::isPassedOptRemarkEnabled(StringRef categoryName) const {
return passedFilter && passedFilter->match(categoryName);
}
bool RemarkEngine::isAnalysisOptRemarkEnabled(StringRef categoryName) const {
return analysisFilter && analysisFilter->match(categoryName);
}
bool RemarkEngine::isFailedOptRemarkEnabled(StringRef categoryName) const {
return failedFilter && failedFilter->match(categoryName);
}
InFlightRemark RemarkEngine::emitOptimizationRemark(Location loc,
RemarkOpts opts) {
return emitIfEnabled<OptRemarkPass>(loc, opts,
&RemarkEngine::isPassedOptRemarkEnabled);
}
InFlightRemark RemarkEngine::emitOptimizationRemarkMiss(Location loc,
RemarkOpts opts) {
return emitIfEnabled<OptRemarkMissed>(
loc, opts, &RemarkEngine::isMissedOptRemarkEnabled);
}
InFlightRemark RemarkEngine::emitOptimizationRemarkFailure(Location loc,
RemarkOpts opts) {
return emitIfEnabled<OptRemarkFailure>(
loc, opts, &RemarkEngine::isFailedOptRemarkEnabled);
}
InFlightRemark RemarkEngine::emitOptimizationRemarkAnalysis(Location loc,
RemarkOpts opts) {
return emitIfEnabled<OptRemarkAnalysis>(
loc, opts, &RemarkEngine::isAnalysisOptRemarkEnabled);
}
//===----------------------------------------------------------------------===//
// RemarkEngine
//===----------------------------------------------------------------------===//
void RemarkEngine::report(const Remark &&remark) {
// Stream the remark
if (remarkStreamer)
remarkStreamer->streamOptimizationRemark(remark);
// Print using MLIR's diagnostic
if (printAsEmitRemarks)
emitRemark(remark.getLocation(), remark.getMsg());
}
RemarkEngine::~RemarkEngine() {
if (remarkStreamer)
remarkStreamer->finalize();
}
llvm::LogicalResult
RemarkEngine::initialize(std::unique_ptr<MLIRRemarkStreamerBase> streamer,
std::string *errMsg) {
// If you need to validate categories/filters, do so here and set errMsg.
remarkStreamer = std::move(streamer);
return success();
}
/// Returns true if filter is already anchored like ^...$
static bool isAnchored(llvm::StringRef s) {
s = s.trim();
return s.starts_with("^") && s.ends_with("$"); // note: startswith/endswith
}
/// Anchor the entire pattern so it matches the whole string.
static std::string anchorWhole(llvm::StringRef filter) {
if (isAnchored(filter))
return filter.str();
return (llvm::Twine("^(") + filter + ")$").str();
}
/// Build a combined filter from cats.all and a category-specific pattern.
/// If neither is present, return std::nullopt. Otherwise "(all|specific)"
/// and anchor once. Also validate before returning.
static std::optional<llvm::Regex>
buildFilter(const mlir::remark::RemarkCategories &cats,
const std::optional<std::string> &specific) {
llvm::SmallVector<llvm::StringRef, 2> parts;
if (cats.all && !cats.all->empty())
parts.emplace_back(*cats.all);
if (specific && !specific->empty())
parts.emplace_back(*specific);
if (parts.empty())
return std::nullopt;
std::string joined = llvm::join(parts, "|");
std::string anchored = anchorWhole(joined);
llvm::Regex rx(anchored);
std::string err;
if (!rx.isValid(err))
return std::nullopt;
return std::make_optional<llvm::Regex>(std::move(rx));
}
RemarkEngine::RemarkEngine(bool printAsEmitRemarks,
const RemarkCategories &cats)
: printAsEmitRemarks(printAsEmitRemarks) {
if (cats.passed)
passedFilter = buildFilter(cats, cats.passed);
if (cats.missed)
missFilter = buildFilter(cats, cats.missed);
if (cats.analysis)
analysisFilter = buildFilter(cats, cats.analysis);
if (cats.failed)
failedFilter = buildFilter(cats, cats.failed);
}
llvm::LogicalResult mlir::remark::enableOptimizationRemarks(
MLIRContext &ctx,
std::unique_ptr<remark::detail::MLIRRemarkStreamerBase> streamer,
const remark::RemarkCategories &cats, bool printAsEmitRemarks) {
auto engine =
std::make_unique<remark::detail::RemarkEngine>(printAsEmitRemarks, cats);
std::string errMsg;
if (failed(engine->initialize(std::move(streamer), &errMsg))) {
llvm::report_fatal_error(
llvm::Twine("Failed to initialize remark engine. Error: ") + errMsg);
}
ctx.setRemarkEngine(std::move(engine));
return success();
}
|