blob: b360ccbadfa5fef76cb45e48163f93bf22a74864 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
|
// RUN: %check_clang_tidy %s readability-redundant-smartptr-get %t
#define NULL __null
namespace std {
// MSVC headers define operator templates instead of plain operators.
template <typename T>
struct unique_ptr {
template <typename T2 = T>
T2& operator*() const;
template <typename T2 = T>
T2* operator->() const;
T* get() const;
explicit operator bool() const noexcept;
};
template <typename T>
struct unique_ptr<T[]> {
template <typename T2 = T>
T2* operator[](unsigned) const;
T* get() const;
explicit operator bool() const noexcept;
};
template <typename T>
struct shared_ptr {
template <typename T2 = T>
T2& operator*() const;
template <typename T2 = T>
T2* operator->() const;
T* get() const;
explicit operator bool() const noexcept;
};
template <typename T>
struct shared_ptr<T[]> {
template <typename T2 = T>
T2* operator[](unsigned) const;
T* get() const;
explicit operator bool() const noexcept;
};
} // namespace std
struct Bar {
void Do();
void ConstDo() const;
};
void Positive() {
std::unique_ptr<Bar>* up;
(*up->get()).Do();
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: redundant get() call
// CHECK-MESSAGES: (*up->get()).Do();
// CHECK-FIXES: (**up).Do();
std::unique_ptr<int> uu;
std::shared_ptr<double> *ss;
bool bb = uu.get() == nullptr;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: redundant get() call
// CHECK-MESSAGES: uu.get() == nullptr;
// CHECK-FIXES: bool bb = uu == nullptr;
if (up->get());
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: redundant get() call
// CHECK-MESSAGES: if (up->get());
// CHECK-FIXES: if (*up);
if ((uu.get()));
// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: redundant get() call
// CHECK-MESSAGES: if ((uu.get()));
// CHECK-FIXES: if ((uu));
bb = !ss->get();
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: redundant get() call
// CHECK-MESSAGES: bb = !ss->get();
// CHECK-FIXES: bb = !*ss;
bb = nullptr != ss->get();
// CHECK-MESSAGES: :[[@LINE-1]]:19: warning: redundant get() call
// CHECK-MESSAGES: nullptr != ss->get();
// CHECK-FIXES: bb = nullptr != *ss;
bb = std::unique_ptr<int>().get() == NULL;
// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: redundant get() call
// CHECK-MESSAGES: bb = std::unique_ptr<int>().get() == NULL;
// CHECK-FIXES: bb = std::unique_ptr<int>() == NULL;
bb = ss->get() == NULL;
// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: redundant get() call
// CHECK-MESSAGES: bb = ss->get() == NULL;
// CHECK-FIXES: bb = *ss == NULL;
std::unique_ptr<int> x, y;
if (x.get() == nullptr);
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: redundant get() call
// CHECK-MESSAGES: if (x.get() == nullptr);
// CHECK-FIXES: if (x == nullptr);
if (nullptr == y.get());
// CHECK-MESSAGES: :[[@LINE-1]]:18: warning: redundant get() call
// CHECK-MESSAGES: if (nullptr == y.get());
// CHECK-FIXES: if (nullptr == y);
if (x.get() == NULL);
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: redundant get() call
// CHECK-MESSAGES: if (x.get() == NULL);
// CHECK-FIXES: if (x == NULL);
if (NULL == x.get());
// CHECK-MESSAGES: :[[@LINE-1]]:15: warning: redundant get() call
// CHECK-MESSAGES: if (NULL == x.get());
// CHECK-FIXES: if (NULL == x);
}
void test_smart_ptr_to_array() {
std::unique_ptr<int[]> i;
// The array specialization does not have operator*(), so make sure
// we do not incorrectly suggest sizeof(*i) here.
// FIXME: alternatively, we could suggest sizeof(i[0])
auto sz = sizeof(*i.get());
std::shared_ptr<Bar[]> s;
// The array specialization does not have operator->() either
s.get()->Do();
bool b1 = !s.get();
// CHECK-MESSAGES: :[[@LINE-1]]:14: warning: redundant get() call
// CHECK-FIXES: bool b1 = !s;
if (s.get()) {}
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: redundant get() call
// CHECK-FIXES: if (s) {}
int x = s.get() ? 1 : 2;
// CHECK-MESSAGES: :[[@LINE-1]]:11: warning: redundant get() call
// CHECK-FIXES: int x = s ? 1 : 2;
bool b2 = s.get() == nullptr;
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: redundant get() call
// CHECK-FIXES: bool b2 = s == nullptr;
}
|
