diff options
Diffstat (limited to 'clang/lib/Format/QualifierAlignmentFixer.cpp')
-rw-r--r-- | clang/lib/Format/QualifierAlignmentFixer.cpp | 31 |
1 files changed, 20 insertions, 11 deletions
diff --git a/clang/lib/Format/QualifierAlignmentFixer.cpp b/clang/lib/Format/QualifierAlignmentFixer.cpp index c0b3345..dd12298 100644 --- a/clang/lib/Format/QualifierAlignmentFixer.cpp +++ b/clang/lib/Format/QualifierAlignmentFixer.cpp @@ -94,9 +94,10 @@ std::pair<tooling::Replacements, unsigned> QualifierAlignmentFixer::analyze( if (!OriginalCode.equals(Fix.getReplacementText())) { auto Err = NonNoOpFixes.add(Fix); - if (Err) + if (Err) { llvm::errs() << "Error adding replacements : " << llvm::toString(std::move(Err)) << "\n"; + } } } return {NonNoOpFixes, 0}; @@ -108,9 +109,10 @@ static void replaceToken(const SourceManager &SourceMgr, auto Replacement = tooling::Replacement(SourceMgr, Range, NewText); auto Err = Fixes.add(Replacement); - if (Err) + if (Err) { llvm::errs() << "Error while rearranging Qualifier : " << llvm::toString(std::move(Err)) << "\n"; + } } static void removeToken(const SourceManager &SourceMgr, @@ -238,8 +240,9 @@ const FormatToken *LeftRightQualifierAlignmentFixer::analyzeRight( // Move to the end of any template class members e.g. // `Foo<int>::iterator`. if (EndTemplate->startsSequence(TT_TemplateCloser, tok::coloncolon, - tok::identifier)) + tok::identifier)) { EndTemplate = EndTemplate->Next->Next; + } } if (EndTemplate && EndTemplate->Next && !EndTemplate->Next->isOneOf(tok::equal, tok::l_paren)) { @@ -263,8 +266,9 @@ const FormatToken *LeftRightQualifierAlignmentFixer::analyzeRight( // Move to the end of any template class members e.g. // `Foo<int>::iterator`. if (Next && Next->startsSequence(TT_TemplateCloser, tok::coloncolon, - tok::identifier)) + tok::identifier)) { return Tok; + } assert(Next && "Missing template opener"); Next = Next->Next; } @@ -324,12 +328,14 @@ const FormatToken *LeftRightQualifierAlignmentFixer::analyzeLeft( } if (Tok->is(TT_TemplateOpener) && Tok->Next && (Tok->Next->is(tok::identifier) || Tok->Next->isSimpleTypeSpecifier()) && - Tok->Next->Next && Tok->Next->Next->is(QualifierType)) + Tok->Next->Next && Tok->Next->Next->is(QualifierType)) { rotateTokens(SourceMgr, Fixes, Tok->Next, Tok->Next->Next, /*Left=*/true); + } if (Tok->startsSequence(tok::identifier) && Tok->Next) { if (Tok->Previous && - Tok->Previous->isOneOf(tok::star, tok::ampamp, tok::amp)) + Tok->Previous->isOneOf(tok::star, tok::ampamp, tok::amp)) { return Tok; + } const FormatToken *Next = Tok->Next; // The case `std::Foo<T> const` -> `const std::Foo<T> &&` while (Next && Next->isOneOf(tok::identifier, tok::coloncolon)) @@ -422,12 +428,13 @@ LeftRightQualifierAlignmentFixer::analyze( Tok = Tok->Next) { if (Tok->is(tok::comment)) continue; - if (RightAlign) + if (RightAlign) { Tok = analyzeRight(SourceMgr, Keywords, Fixes, Tok, Qualifier, QualifierToken); - else + } else { Tok = analyzeLeft(SourceMgr, Keywords, Fixes, Tok, Qualifier, QualifierToken); + } } } return {Fixes, 0}; @@ -458,11 +465,12 @@ void QualifierAlignmentFixer::PrepareLeftRightOrdering( if (QualifierToken != tok::kw_typeof && QualifierToken != tok::identifier) Qualifiers.push_back(QualifierToken); - if (left) + if (left) { // Reverse the order for left aligned items. LeftOrder.insert(LeftOrder.begin(), s); - else + } else { RightOrder.push_back(s); + } } } @@ -479,9 +487,10 @@ bool LeftRightQualifierAlignmentFixer::isPossibleMacro(const FormatToken *Tok) { return false; if (!Tok->is(tok::identifier)) return false; - if (Tok->TokenText.upper() == Tok->TokenText.str()) + if (Tok->TokenText.upper() == Tok->TokenText.str()) { // T,K,U,V likely could be template arguments return (Tok->TokenText.size() != 1); + } return false; } |