diff options
author | Matt Arsenault <Matthew.Arsenault@amd.com> | 2019-12-30 12:05:25 -0500 |
---|---|---|
committer | Matt Arsenault <arsenm2@gmail.com> | 2019-12-30 14:24:25 -0500 |
commit | 94d08feaeff3591a36ed548ba7c732ddedd6f983 (patch) | |
tree | eae2f420e6a5c2dbe523e50c1e0ebe59608a46b7 /llvm/utils/TableGen/CodeGenDAGPatterns.cpp | |
parent | 47a2fd2df4f4874c28823654be500c3aba93f768 (diff) | |
download | llvm-94d08feaeff3591a36ed548ba7c732ddedd6f983.zip llvm-94d08feaeff3591a36ed548ba7c732ddedd6f983.tar.gz llvm-94d08feaeff3591a36ed548ba7c732ddedd6f983.tar.bz2 |
TableGen: Fix assert on PatFrags with predicate code
This assumed a single pattern if there was a predicate. Relax this a
bit, and allow multiple patterns as long as they have the same class.
This was only broken for the DAG path. GlobalISel seems to have
handled this correctly already.
Diffstat (limited to 'llvm/utils/TableGen/CodeGenDAGPatterns.cpp')
-rw-r--r-- | llvm/utils/TableGen/CodeGenDAGPatterns.cpp | 26 |
1 files changed, 21 insertions, 5 deletions
diff --git a/llvm/utils/TableGen/CodeGenDAGPatterns.cpp b/llvm/utils/TableGen/CodeGenDAGPatterns.cpp index d01de33..7e0ba98 100644 --- a/llvm/utils/TableGen/CodeGenDAGPatterns.cpp +++ b/llvm/utils/TableGen/CodeGenDAGPatterns.cpp @@ -1315,13 +1315,29 @@ std::string TreePredicateFn::getCodeToRunOnSDNode() const { // Handle arbitrary node predicates. assert(hasPredCode() && "Don't have any predicate code!"); + + // If this is using PatFrags, there are multiple trees to search. They should + // all have the same class. FIXME: Is there a way to find a common + // superclass? StringRef ClassName; - if (PatFragRec->getOnlyTree()->isLeaf()) - ClassName = "SDNode"; - else { - Record *Op = PatFragRec->getOnlyTree()->getOperator(); - ClassName = PatFragRec->getDAGPatterns().getSDNodeInfo(Op).getSDClassName(); + for (const auto &Tree : PatFragRec->getTrees()) { + StringRef TreeClassName; + if (Tree->isLeaf()) + TreeClassName = "SDNode"; + else { + Record *Op = Tree->getOperator(); + const SDNodeInfo &Info = PatFragRec->getDAGPatterns().getSDNodeInfo(Op); + TreeClassName = Info.getSDClassName(); + } + + if (ClassName.empty()) + ClassName = TreeClassName; + else if (ClassName != TreeClassName) { + PrintFatalError(getOrigPatFragRecord()->getRecord()->getLoc(), + "PatFrags trees do not have consistent class"); + } } + std::string Result; if (ClassName == "SDNode") Result = " SDNode *N = Node;\n"; |