diff options
author | Simon Wallis <simon.wallis2@arm.com> | 2020-05-13 10:40:14 +0100 |
---|---|---|
committer | Simon Wallis <simon.wallis2@arm.com> | 2020-05-13 13:52:30 +0100 |
commit | 410644fbf767d5853f170cb2d664a5fef37cb20a (patch) | |
tree | 51ecb2b2beebe359252084b272652af74c9f9d6d /llvm/utils/FileCheck/FileCheck.cpp | |
parent | 9529597cf4562c64034943dacc29a4ff4fe93d86 (diff) | |
download | llvm-410644fbf767d5853f170cb2d664a5fef37cb20a.zip llvm-410644fbf767d5853f170cb2d664a5fef37cb20a.tar.gz llvm-410644fbf767d5853f170cb2d664a5fef37cb20a.tar.bz2 |
Clang crash targeting ARM or Thumb when assembling a prel31 relocation variant
Summary:
In the assembler or inline assembler,
attempting to use an invalid fixup type
gives a crash with a segmentation fault.
__attribute__((naked))
void foo(void) {
__asm__("mov r9, :lower16:bar(prel31)");
}
This should give a proper error message when building for ARM or Thumb.
This brings it in line with AARCH64.
This fixes all 8 instances of llvm_unreachable("Unsupported Modifier");
in ARM/MCTargetDesc/ARMELFObjectWriter.cpp.
A test is provided for each instance.
Reviewers: llvm-commits, MarkMurrayARM
Reviewed By: MarkMurrayARM
Subscribers: kristof.beyls, hiraditya, danielkiss
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D79782
Change-Id: I6971ba37f129cc453568fe71514ccb2ac9d16831
Diffstat (limited to 'llvm/utils/FileCheck/FileCheck.cpp')
0 files changed, 0 insertions, 0 deletions