diff options
| author | Med Ismail Bennani <ismail@bennani.ma> | 2024-05-09 13:51:52 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-09 13:51:52 -0700 |
| commit | f4a7e1f9bac1f11e1db1c0a895f3f681838f89f2 (patch) | |
| tree | d8501df522c2afbe7c28a92e4d658660c7af3d47 /llvm/unittests/TargetParser/TargetParserTest.cpp | |
| parent | ddad7c3c84a8706ad539f1a69660a31a00b411a2 (diff) | |
| download | llvm-f4a7e1f9bac1f11e1db1c0a895f3f681838f89f2.zip llvm-f4a7e1f9bac1f11e1db1c0a895f3f681838f89f2.tar.gz llvm-f4a7e1f9bac1f11e1db1c0a895f3f681838f89f2.tar.bz2 | |
[lldb/crashlog] Fix module binary resolution (#91631)
This patch fixes a bug in when resolving and loading modules from the
binary image list.
When loading a module, we would first use the UUID from the binary image
list with `dsymForUUID` to fetch the dSYM bundle from our remote build
records and copy the executable locally.
If we failed to find a matching dSYM bundle for that UUID on the build
record, let's say if that module was built locally, we use Spotlight
(`mdfind`) to find the dSYM bundle once again using the UUID.
Prior to this patch, we would set the image path to be the same as the
symbol file. This resulted in trying to load the dSYM as a module in
lldb, which isn't allowed.
This patch address that by looking for a binary matching the image
identifier, next to the dSYM bundle and try to load that instead.
rdar://127433616
Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
Diffstat (limited to 'llvm/unittests/TargetParser/TargetParserTest.cpp')
0 files changed, 0 insertions, 0 deletions