diff options
author | Fred Riss <friss@apple.com> | 2020-05-08 15:14:14 -0700 |
---|---|---|
committer | Fred Riss <friss@apple.com> | 2020-05-12 11:55:25 -0700 |
commit | d9166ad272847e246799afbb5e0c71874f83aa12 (patch) | |
tree | adf10d763a3f55afe41dd664b17f85fb4f83b5ed /llvm/unittests/Support/VirtualFileSystemTest.cpp | |
parent | aa99da5ace4587440973c97a4cd5f486e7bb3c33 (diff) | |
download | llvm-d9166ad272847e246799afbb5e0c71874f83aa12.zip llvm-d9166ad272847e246799afbb5e0c71874f83aa12.tar.gz llvm-d9166ad272847e246799afbb5e0c71874f83aa12.tar.bz2 |
[lldb/Driver] Support terminal resizing
Summary:
The comment in the Editine.h header made it sound like editline was
just unable to handle terminal resizing. We were not ever telling
editline that the terminal had changed size, which might explain why
it wasn't working.
This patch threads a `TerminalSizeChanged()` callback through the
IOHandler and invokes it from the SIGWINCH handler in the driver. Our
`Editline` class already had a `TerminalSizeChanged()` method which
was invoked only when editline was configured.
This patch also changes `Editline` to not apply the changes right away
in `TerminalSizeChanged()`, but instead defer that to the next
character read. During my testing, it happened once that the signal
was received while our `ConnectionFileDescriptor::Read` was allocating
memory. As `el_resize` seems to allocate memory too, this crashed.
Reviewers: labath, teemperor
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D79654
Diffstat (limited to 'llvm/unittests/Support/VirtualFileSystemTest.cpp')
0 files changed, 0 insertions, 0 deletions