aboutsummaryrefslogtreecommitdiff
path: root/llvm/unittests/ADT/StringRefTest.cpp
diff options
context:
space:
mode:
authorSimon Pilgrim <llvm-dev@redking.me.uk>2019-07-09 12:20:04 +0000
committerSimon Pilgrim <llvm-dev@redking.me.uk>2019-07-09 12:20:04 +0000
commite995ce5498fe255b2a9f69dceb39044de4e8651f (patch)
tree63e63ec33ab71d6012f915f457251e8d89683cc4 /llvm/unittests/ADT/StringRefTest.cpp
parent4bc20fa149485f7b43f11cc4514b1d9aa926259b (diff)
downloadllvm-e995ce5498fe255b2a9f69dceb39044de4e8651f.zip
llvm-e995ce5498fe255b2a9f69dceb39044de4e8651f.tar.gz
llvm-e995ce5498fe255b2a9f69dceb39044de4e8651f.tar.bz2
[ADT] Enable ArrayRef/StringRef is_assignable tests on MSVC
Now that we've dropped VS2015 support (D64326) we can enable these static_asserts on MSVC builds as VS2017+ correctly handles them llvm-svn: 365471
Diffstat (limited to 'llvm/unittests/ADT/StringRefTest.cpp')
-rw-r--r--llvm/unittests/ADT/StringRefTest.cpp6
1 files changed, 0 insertions, 6 deletions
diff --git a/llvm/unittests/ADT/StringRefTest.cpp b/llvm/unittests/ADT/StringRefTest.cpp
index 6f83dc3..a45e83c 100644
--- a/llvm/unittests/ADT/StringRefTest.cpp
+++ b/llvm/unittests/ADT/StringRefTest.cpp
@@ -34,10 +34,6 @@ std::ostream &operator<<(std::ostream &OS,
// Check that we can't accidentally assign a temporary std::string to a
// StringRef. (Unfortunately we can't make use of the same thing with
// constructors.)
-//
-// Disable this check under MSVC; even MSVC 2015 isn't consistent between
-// std::is_assignable and actually writing such an assignment.
-#if !defined(_MSC_VER)
static_assert(
!std::is_assignable<StringRef&, std::string>::value,
"Assigning from prvalue std::string");
@@ -56,8 +52,6 @@ static_assert(
static_assert(
std::is_assignable<StringRef&, const char * &>::value,
"Assigning from lvalue C string");
-#endif
-
namespace {
TEST(StringRefTest, Construction) {