diff options
| author | Johannes Doerfert <johannes@jdoerfert.de> | 2019-12-24 17:25:37 -0600 |
|---|---|---|
| committer | Johannes Doerfert <johannes@jdoerfert.de> | 2019-12-24 18:30:41 -0600 |
| commit | 9f6b13e5cce96066d7262d224c971d93c2724795 (patch) | |
| tree | 9c6f399d19ea75ac2270657902bfffa0042df6ae /llvm/unittests/ADT/StringRefTest.cpp | |
| parent | a36ddf0aa9db5c1086e04f56b5f077b761712eb5 (diff) | |
| download | llvm-9f6b13e5cce96066d7262d224c971d93c2724795.zip llvm-9f6b13e5cce96066d7262d224c971d93c2724795.tar.gz llvm-9f6b13e5cce96066d7262d224c971d93c2724795.tar.bz2 | |
[Support] Fix behavior of StringRef::count with overlapping occurrences, add tests
Summary:
Fix the behavior of StringRef::count(StringRef) to not count overlapping occurrences, as is stated in the documentation.
Fixes bug https://bugs.llvm.org/show_bug.cgi?id=44072
I added Krzysztof Parzyszek to review this change because a use of this function in HexagonInstrInfo::getInlineAsmLength might depend on the overlapping-behavior. I don't have enough domain knowledge to tell if this change could break anything there.
All other uses of this method in LLVM (besides the unit tests) only use single-character search strings. In those cases, search occurrences can not overlap anyway.
Patch by Benno (@Bensge)
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D70585
Diffstat (limited to 'llvm/unittests/ADT/StringRefTest.cpp')
| -rw-r--r-- | llvm/unittests/ADT/StringRefTest.cpp | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/llvm/unittests/ADT/StringRefTest.cpp b/llvm/unittests/ADT/StringRefTest.cpp index 2e5159d..cbb2a30 100644 --- a/llvm/unittests/ADT/StringRefTest.cpp +++ b/llvm/unittests/ADT/StringRefTest.cpp @@ -509,6 +509,13 @@ TEST(StringRefTest, Count) { EXPECT_EQ(1U, Str.count("hello")); EXPECT_EQ(1U, Str.count("ello")); EXPECT_EQ(0U, Str.count("zz")); + + StringRef OverlappingAbba("abbabba"); + EXPECT_EQ(1U, OverlappingAbba.count("abba")); + StringRef NonOverlappingAbba("abbaabba"); + EXPECT_EQ(2U, NonOverlappingAbba.count("abba")); + StringRef ComplexAbba("abbabbaxyzabbaxyz"); + EXPECT_EQ(2U, ComplexAbba.count("abba")); } TEST(StringRefTest, EditDistance) { |