diff options
| author | Benjamin Kramer <benny.kra@googlemail.com> | 2023-01-15 20:56:34 +0100 |
|---|---|---|
| committer | Benjamin Kramer <benny.kra@googlemail.com> | 2023-01-15 20:59:21 +0100 |
| commit | 931d04be2fc8f3f0505b43e64297f75d526cb42a (patch) | |
| tree | 52dc76aca04bc7877f4fee8e5e70cb3d87d905a3 /llvm/unittests/ADT/StringRefTest.cpp | |
| parent | d9415cd0241ebd7d426d0827ee0c65649018f90b (diff) | |
| download | llvm-931d04be2fc8f3f0505b43e64297f75d526cb42a.zip llvm-931d04be2fc8f3f0505b43e64297f75d526cb42a.tar.gz llvm-931d04be2fc8f3f0505b43e64297f75d526cb42a.tar.bz2 | |
[ADT] Make StringRef::compare like std::string_view::compare
string_view has a slightly weaker contract, which only specifies whether
the value is bigger or smaller than 0. Adapt users accordingly and just
forward to the standard function (that also compiles down to memcmp)
Diffstat (limited to 'llvm/unittests/ADT/StringRefTest.cpp')
| -rw-r--r-- | llvm/unittests/ADT/StringRefTest.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/llvm/unittests/ADT/StringRefTest.cpp b/llvm/unittests/ADT/StringRefTest.cpp index 4ea1ea54..cad1974 100644 --- a/llvm/unittests/ADT/StringRefTest.cpp +++ b/llvm/unittests/ADT/StringRefTest.cpp @@ -81,12 +81,12 @@ TEST(StringRefTest, StringOps) { EXPECT_EQ(p, StringRef(p, 0).data()); EXPECT_TRUE(StringRef().empty()); EXPECT_EQ((size_t) 5, StringRef("hello").size()); - EXPECT_EQ(-1, StringRef("aab").compare("aad")); + EXPECT_GT( 0, StringRef("aab").compare("aad")); EXPECT_EQ( 0, StringRef("aab").compare("aab")); - EXPECT_EQ( 1, StringRef("aab").compare("aaa")); - EXPECT_EQ(-1, StringRef("aab").compare("aabb")); - EXPECT_EQ( 1, StringRef("aab").compare("aa")); - EXPECT_EQ( 1, StringRef("\xFF").compare("\1")); + EXPECT_LT( 0, StringRef("aab").compare("aaa")); + EXPECT_GT( 0, StringRef("aab").compare("aabb")); + EXPECT_LT( 0, StringRef("aab").compare("aa")); + EXPECT_LT( 0, StringRef("\xFF").compare("\1")); EXPECT_EQ(-1, StringRef("AaB").compare_insensitive("aAd")); EXPECT_EQ( 0, StringRef("AaB").compare_insensitive("aab")); |