diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-08-19 18:44:46 +0000 | 
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-08-19 18:44:46 +0000 | 
| commit | 48af1c2a1a5148bc6a143bc0d8650ef744f2f7c3 (patch) | |
| tree | b702bea9017a8fb461da713a083af53f596b95ef /llvm/unittests/ADT/ArrayRefTest.cpp | |
| parent | f17f03e00e5dc20f2cdbfbd4cc36e47a8966d2f7 (diff) | |
| download | llvm-48af1c2a1a5148bc6a143bc0d8650ef744f2f7c3.zip llvm-48af1c2a1a5148bc6a143bc0d8650ef744f2f7c3.tar.gz llvm-48af1c2a1a5148bc6a143bc0d8650ef744f2f7c3.tar.bz2 | |
Don't own the buffer in object::Binary.
Owning the buffer is somewhat inflexible. Some Binaries have sub Binaries
(like Archive) and we had to create dummy buffers just to handle that. It is
also a bad fit for IRObjectFile where the Module wants to own the buffer too.
Keeping this ownership would make supporting IR inside native objects
particularly painful.
This patch focuses in lib/Object. If something elsewhere used to own an Binary,
now it also owns a MemoryBuffer.
This patch introduces a few new types.
* MemoryBufferRef. This is just a pair of StringRefs for the data and name.
  This is to MemoryBuffer as StringRef is to std::string.
* OwningBinary. A combination of Binary and a MemoryBuffer. This is needed
  for convenience functions that take a filename and return both the
  buffer and the Binary using that buffer.
The C api now uses OwningBinary to avoid any change in semantics. I will start
a new thread to see if we want to change it and how.
llvm-svn: 216002
Diffstat (limited to 'llvm/unittests/ADT/ArrayRefTest.cpp')
0 files changed, 0 insertions, 0 deletions
