aboutsummaryrefslogtreecommitdiff
path: root/llvm/tools/llvm-reduce/ReducerWorkItem.cpp
diff options
context:
space:
mode:
authorEli Friedman <efriedma@quicinc.com>2022-08-16 16:15:44 -0700
committerEli Friedman <efriedma@quicinc.com>2022-08-16 16:15:44 -0700
commitcfd2c5ce580fce744f6fd6ba34e869cab05e94c3 (patch)
treeca1395331cdc448d042dd192c0856e7a9c141943 /llvm/tools/llvm-reduce/ReducerWorkItem.cpp
parentd9198f64d9be149acdad109cd053b6acdd9635d2 (diff)
downloadllvm-cfd2c5ce580fce744f6fd6ba34e869cab05e94c3.zip
llvm-cfd2c5ce580fce744f6fd6ba34e869cab05e94c3.tar.gz
llvm-cfd2c5ce580fce744f6fd6ba34e869cab05e94c3.tar.bz2
Untangle the mess which is MachineBasicBlock::hasAddressTaken().
There are two different senses in which a block can be "address-taken". There can be a BlockAddress involved, which means we need to map the IR-level value to some specific block of machine code. Or there can be constructs inside a function which involve using the address of a basic block to implement certain kinds of control flow. Mixing these together causes a problem: if target-specific passes are marking random blocks "address-taken", if we have a BlockAddress, we can't actually tell which MachineBasicBlock corresponds to the BlockAddress. So split this into two separate bits: one for BlockAddress, and one for the machine-specific bits. Discovered while trying to sort out related stuff on D102817. Differential Revision: https://reviews.llvm.org/D124697
Diffstat (limited to 'llvm/tools/llvm-reduce/ReducerWorkItem.cpp')
-rw-r--r--llvm/tools/llvm-reduce/ReducerWorkItem.cpp6
1 files changed, 4 insertions, 2 deletions
diff --git a/llvm/tools/llvm-reduce/ReducerWorkItem.cpp b/llvm/tools/llvm-reduce/ReducerWorkItem.cpp
index b6e78dd..cd2b763 100644
--- a/llvm/tools/llvm-reduce/ReducerWorkItem.cpp
+++ b/llvm/tools/llvm-reduce/ReducerWorkItem.cpp
@@ -206,8 +206,10 @@ static std::unique_ptr<MachineFunction> cloneMF(MachineFunction *SrcMF,
DstMF->CreateMachineBasicBlock(SrcMBB.getBasicBlock());
Src2DstMBB[&SrcMBB] = DstMBB;
- if (SrcMBB.hasAddressTaken())
- DstMBB->setHasAddressTaken();
+ if (SrcMBB.isIRBlockAddressTaken())
+ DstMBB->setAddressTakenIRBlock(SrcMBB.getAddressTakenIRBlock());
+ if (SrcMBB.isMachineBlockAddressTaken())
+ DstMBB->setMachineBlockAddressTaken();
// FIXME: This is not serialized
if (SrcMBB.hasLabelMustBeEmitted())