diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2015-06-30 03:33:18 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2015-06-30 03:33:18 +0000 |
| commit | f69ac42ac401aa0b0f17d47eea9531ec0d566e98 (patch) | |
| tree | cb3856e96102866765f89bc38e347b835a03fcc1 /llvm/tools/llvm-objdump/llvm-objdump.cpp | |
| parent | 149e6031323d6507860909a5cbb449fb2d0e0210 (diff) | |
| download | llvm-f69ac42ac401aa0b0f17d47eea9531ec0d566e98.zip llvm-f69ac42ac401aa0b0f17d47eea9531ec0d566e98.tar.gz llvm-f69ac42ac401aa0b0f17d47eea9531ec0d566e98.tar.bz2 | |
Don't return error_code from a function that doesn't fail.
llvm-svn: 241039
Diffstat (limited to 'llvm/tools/llvm-objdump/llvm-objdump.cpp')
| -rw-r--r-- | llvm/tools/llvm-objdump/llvm-objdump.cpp | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp index 6282c51..08a361f 100644 --- a/llvm/tools/llvm-objdump/llvm-objdump.cpp +++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp @@ -888,13 +888,12 @@ static void DisassembleObject(const ObjectFile *Obj, bool InlineRelocs) { // Print relocation for instruction. while (rel_cur != rel_end) { - bool hidden = false; + bool hidden = rel_cur->getHidden(); uint64_t addr = rel_cur->getOffset(); SmallString<16> name; SmallString<32> val; // If this relocation is hidden, skip it. - if (error(rel_cur->getHidden(hidden))) goto skip_print_rel; if (hidden) goto skip_print_rel; // Stop when rel_cur's address is past the current instruction. @@ -929,12 +928,10 @@ void llvm::PrintRelocations(const ObjectFile *Obj) { continue; outs() << "RELOCATION RECORDS FOR [" << secname << "]:\n"; for (const RelocationRef &Reloc : Section.relocations()) { - bool hidden; + bool hidden = Reloc.getHidden(); uint64_t address = Reloc.getOffset(); SmallString<32> relocname; SmallString<32> valuestr; - if (error(Reloc.getHidden(hidden))) - continue; if (hidden) continue; if (error(Reloc.getTypeName(relocname))) |