diff options
author | Fangrui Song <i@maskray.me> | 2023-12-18 09:46:58 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-12-18 09:46:58 -0800 |
commit | 96aca7c51701f9b3c5dd8567fcddf29492008e6d (patch) | |
tree | 34367303d01dd280981125de0d6849baaef99b6d /llvm/tools/llvm-objdump/llvm-objdump.cpp | |
parent | 672f1a036a28cf993e7b5b022bd5582a8924ee58 (diff) | |
download | llvm-96aca7c51701f9b3c5dd8567fcddf29492008e6d.zip llvm-96aca7c51701f9b3c5dd8567fcddf29492008e6d.tar.gz llvm-96aca7c51701f9b3c5dd8567fcddf29492008e6d.tar.bz2 |
[LTO] Improve diagnostics handling when parsing module-level inline assembly (#75726)
Non-LTO compiles set the buffer name to "<inline asm>"
(`AsmPrinter::addInlineAsmDiagBuffer`) and pass diagnostics to
`ClangDiagnosticHandler` (through the `MCContext` handler in
`MachineModuleInfoWrapperPass::doInitialization`) to ensure that
the exit code is 1 in the presence of errors. In contrast, LTO compiles
spuriously succeed even if error messages are printed.
```
% cat a.c
void _start() {}
asm("unknown instruction");
% clang -c a.c
<inline asm>:1:1: error: invalid instruction mnemonic 'unknown'
1 | unknown instruction
| ^
1 error generated.
% clang -c -flto a.c; echo $? # -flto=thin is the same
error: invalid instruction mnemonic 'unknown'
unknown instruction
^~~~~~~
error: invalid instruction mnemonic 'unknown'
unknown instruction
^~~~~~~
0
```
`CollectAsmSymbols` parses inline assembly and is transitively called by
both `ModuleSummaryIndexAnalysis::run` and `WriteBitcodeToFile`, leading
to duplicate diagnostics.
This patch updates `CollectAsmSymbols` to be similar to non-LTO
compiles.
```
% clang -c -flto=thin a.c; echo $?
<inline asm>:1:1: error: invalid instruction mnemonic 'unknown'
1 | unknown instruction
| ^
1 errors generated.
1
```
The `HasErrors` check does not prevent duplicate warnings but assembler
warnings are very uncommon.
Diffstat (limited to 'llvm/tools/llvm-objdump/llvm-objdump.cpp')
0 files changed, 0 insertions, 0 deletions