diff options
author | Fangrui Song <i@maskray.me> | 2023-05-03 21:20:54 -0700 |
---|---|---|
committer | Fangrui Song <i@maskray.me> | 2023-05-03 21:20:54 -0700 |
commit | 7aeb1536a1a1c1b9ffd6180a8d3824c7a1d7b2cf (patch) | |
tree | fbcd293bd40aae859298e3037e5b41a9d163358d /llvm/tools/llvm-objdump/llvm-objdump.cpp | |
parent | b50f733c20126209affed392bdb0252d8faefaf6 (diff) | |
download | llvm-7aeb1536a1a1c1b9ffd6180a8d3824c7a1d7b2cf.zip llvm-7aeb1536a1a1c1b9ffd6180a8d3824c7a1d7b2cf.tar.gz llvm-7aeb1536a1a1c1b9ffd6180a8d3824c7a1d7b2cf.tar.bz2 |
[llvm-objdump] addPltEntries: reduce indentation. NFC
Diffstat (limited to 'llvm/tools/llvm-objdump/llvm-objdump.cpp')
-rw-r--r-- | llvm/tools/llvm-objdump/llvm-objdump.cpp | 37 |
1 files changed, 19 insertions, 18 deletions
diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp index 5abcdcc..8e372cb 100644 --- a/llvm/tools/llvm-objdump/llvm-objdump.cpp +++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp @@ -914,6 +914,9 @@ addMissingWasmCodeSymbols(const WasmObjectFile &Obj, static void addPltEntries(const ObjectFile &Obj, std::map<SectionRef, SectionSymbolsTy> &AllSymbols, StringSaver &Saver) { + auto *ElfObj = dyn_cast<ELFObjectFileBase>(&Obj); + if (!ElfObj) + return; std::optional<SectionRef> Plt; for (const SectionRef &Section : Obj.sections()) { Expected<StringRef> SecNameOrErr = Section.getName(); @@ -926,26 +929,24 @@ static void addPltEntries(const ObjectFile &Obj, } if (!Plt) return; - if (auto *ElfObj = dyn_cast<ELFObjectFileBase>(&Obj)) { - for (auto PltEntry : ElfObj->getPltAddresses()) { - if (PltEntry.first) { - SymbolRef Symbol(*PltEntry.first, ElfObj); - uint8_t SymbolType = getElfSymbolType(Obj, Symbol); - if (Expected<StringRef> NameOrErr = Symbol.getName()) { - if (!NameOrErr->empty()) - AllSymbols[*Plt].emplace_back( - PltEntry.second, Saver.save((*NameOrErr + "@plt").str()), - SymbolType); - continue; - } else { - // The warning has been reported in disassembleObject(). - consumeError(NameOrErr.takeError()); - } + for (auto PltEntry : ElfObj->getPltAddresses()) { + if (PltEntry.first) { + SymbolRef Symbol(*PltEntry.first, ElfObj); + uint8_t SymbolType = getElfSymbolType(Obj, Symbol); + if (Expected<StringRef> NameOrErr = Symbol.getName()) { + if (!NameOrErr->empty()) + AllSymbols[*Plt].emplace_back( + PltEntry.second, Saver.save((*NameOrErr + "@plt").str()), + SymbolType); + continue; + } else { + // The warning has been reported in disassembleObject(). + consumeError(NameOrErr.takeError()); } - reportWarning("PLT entry at 0x" + Twine::utohexstr(PltEntry.second) + - " references an invalid symbol", - Obj.getFileName()); } + reportWarning("PLT entry at 0x" + Twine::utohexstr(PltEntry.second) + + " references an invalid symbol", + Obj.getFileName()); } } |