diff options
author | JF Bastien <jfbastien@apple.com> | 2018-06-01 04:59:48 +0000 |
---|---|---|
committer | JF Bastien <jfbastien@apple.com> | 2018-06-01 04:59:48 +0000 |
commit | 766128e6971a88b07834822ff857958283666cc0 (patch) | |
tree | f5938cbd526e3ff6e9720d2bd249a02ca07fc59c /llvm/tools/llvm-objdump/llvm-objdump.cpp | |
parent | 5b1dd01e57dcc33076fcd67e7cf6ed63a3467912 (diff) | |
download | llvm-766128e6971a88b07834822ff857958283666cc0.zip llvm-766128e6971a88b07834822ff857958283666cc0.tar.gz llvm-766128e6971a88b07834822ff857958283666cc0.tar.bz2 |
Filesystem tests: un-confuse write time
Summary:
The filesystem test was confused about access versus write / modification time. The spec says:
file_time_type last_write_time(const path& p, error_code& ec) noexcept;
Returns: The time of last data modification of p, determined as if by the value of the POSIX stat structure member st_mtime obtained as if by POSIX stat(). The signature with argument ec returns file_time_type::min() if an error occurs.
The test was looking at st_atime, not st_mtime, when comparing the result from last_write_time. That was probably due to using a pair instead of naming things nicely or using types. I opted to rename things so it's clearer.
This used to cause test bot failures.
<rdar://problem/40648859>
Reviewers: EricWF, mclow.lists, aemerson
Subscribers: christof, cfe-commits
Differential Revision: https://reviews.llvm.org/D47557
llvm-svn: 333723
Diffstat (limited to 'llvm/tools/llvm-objdump/llvm-objdump.cpp')
0 files changed, 0 insertions, 0 deletions