aboutsummaryrefslogtreecommitdiff
path: root/llvm/tools/llvm-objdump/llvm-objdump.cpp
diff options
context:
space:
mode:
authorjeffreytan81 <jeffreytan@meta.com>2024-04-18 09:24:33 -0700
committerGitHub <noreply@github.com>2024-04-18 09:24:33 -0700
commit6870ac201f9f50a13313213fea7a14b198d7280a (patch)
tree995ef92eb295f9f2c8b366a894732aa6467e7df4 /llvm/tools/llvm-objdump/llvm-objdump.cpp
parent215eee60497489ae0cc7cc78c0d8b8270e057a70 (diff)
downloadllvm-6870ac201f9f50a13313213fea7a14b198d7280a.zip
llvm-6870ac201f9f50a13313213fea7a14b198d7280a.tar.gz
llvm-6870ac201f9f50a13313213fea7a14b198d7280a.tar.bz2
Fix saving minidump from lldb-dap (#89113)
There are users reporting saving minidump from lldb-dap does not work. Turns out our stack trace request always evaluate a function call which caused JIT object file like "__lldb_caller_function" to be created which can fail minidump builder to get its module size. This patch fixes "getModuleFileSize" for ObjectFileJIT so that module list can be saved. I decided to create a lldb-dap test so that this end-to-end functionality can be validated from our tests (instead of only command line lldb). The patch also improves several other small things in the workflow: 1. It logs any minidump stream failure so that it is easier to find out what stream saving fails. In future, we should show process and error to end users. 2. It handles error from "getModuleFileSize" llvm::Expected<T> otherwise it will complain the error is not handled. --------- Co-authored-by: jeffreytan81 <jeffreytan@fb.com>
Diffstat (limited to 'llvm/tools/llvm-objdump/llvm-objdump.cpp')
0 files changed, 0 insertions, 0 deletions