diff options
| author | Pavel Labath <labath@google.com> | 2016-08-17 08:53:31 +0000 |
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2016-08-17 08:53:31 +0000 |
| commit | 56d7262b698024ba95afe5df5355e7cc23933049 (patch) | |
| tree | f4587b04e46d7bf09ff90afa9e7aa3c6ca1c7cf4 /llvm/tools/llvm-objdump/llvm-objdump.cpp | |
| parent | 206fffa1926a0a3741210edb35897f4546c90dd3 (diff) | |
| download | llvm-56d7262b698024ba95afe5df5355e7cc23933049.zip llvm-56d7262b698024ba95afe5df5355e7cc23933049.tar.gz llvm-56d7262b698024ba95afe5df5355e7cc23933049.tar.bz2 | |
Move packet construction from GDBRemoteRegisterContext go the communication class
Summary:
When saving/restoring registers the GDBRemoteRegisterContext class was manually constructing
the register save/restore packets. This creates appropriate helper functions in
GDBRemoteCommunicationClient, and switches the class to use those. It also removes what a
duplicate packet send in some of those functions, a thing that I can only attribute to a bad
merge artefact.
I also add a test framework for testing gdb-remote client functionality and add tests for the new
functions I introduced. I'd like to be able to test the register context changes in isolation as
well, but currently there doesn't seem to be a way to reasonably construct a standalone register
context object, so we'll have to rely on the end-to-end tests to verify that.
Reviewers: clayborg
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D23553
llvm-svn: 278915
Diffstat (limited to 'llvm/tools/llvm-objdump/llvm-objdump.cpp')
0 files changed, 0 insertions, 0 deletions