diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2011-09-07 08:05:58 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2011-09-07 08:05:58 +0000 |
| commit | 3d45b23dfcdecb4434389daa8b1f1dbea81e7cc5 (patch) | |
| tree | d82afaa2e8d8392a3df57b0b95a333eb609667f4 /llvm/tools/llvm-objdump/llvm-objdump.cpp | |
| parent | 97798305130e7f3c7152423d8df56bf9ec12cdf6 (diff) | |
| download | llvm-3d45b23dfcdecb4434389daa8b1f1dbea81e7cc5.zip llvm-3d45b23dfcdecb4434389daa8b1f1dbea81e7cc5.tar.gz llvm-3d45b23dfcdecb4434389daa8b1f1dbea81e7cc5.tar.bz2 | |
Extract the emission of the diagnostic's location into a separate
function. This is really the beginning of the second phase of
refactorings here. The end goal is to have (roughly) three interfaces:
1) Base class to format a single diagnostic suitable for display on the
console.
2) Extension of the base class which also displays a caret diagnostic
suitable for display on the console.
3) An adaptor that implements the DiagnosticClient by delegating to #1
and/or #2 as appropriate.
Once we have these, things like libclang's formatDiagnostic can use #1
and #2 to provide really well formatted (and consistently formatted!)
textual formatting of diagnostics.
Getting there is going to be quite a bit of shuffling. I'm basically
sketching out where the interface boundaries can be drawn for #1 and #2
within the existing classes. That lets me shuffle with a minimum of fuss
and delta. Once that's done, and any of the related interfaces that need
to change are updated, I'll hoist these into separate headers and
re-implement libclang in terms of their interfaces. Long WIP, but
comments at each step welcome. =D
llvm-svn: 139228
Diffstat (limited to 'llvm/tools/llvm-objdump/llvm-objdump.cpp')
0 files changed, 0 insertions, 0 deletions
