diff options
| author | Kadir Cetinkaya <kadircet@google.com> | 2020-04-07 20:08:55 +0200 |
|---|---|---|
| committer | Kadir Cetinkaya <kadircet@google.com> | 2020-04-08 09:57:55 +0200 |
| commit | 130dbf63ff12271be9451e259447c5fab768dce6 (patch) | |
| tree | 2ba74345e78b7596d02d1fb9e8fa108bc49ad4ae /llvm/tools/llvm-objdump/llvm-objdump.cpp | |
| parent | aa034867f1ddadb3de0c6357ce4433d8242de2a6 (diff) | |
| download | llvm-130dbf63ff12271be9451e259447c5fab768dce6.zip llvm-130dbf63ff12271be9451e259447c5fab768dce6.tar.gz llvm-130dbf63ff12271be9451e259447c5fab768dce6.tar.bz2 | |
[clangd] Fix broken assertion
Summary:
This assertion was bad. It will show up once we start running preamble
thread async. Think about the following case:
- Update 1
builds a preamble, and an AST. Caches the AST.
- Update 2
Invalidates the cache, preamble hasn't changed.
- Update 3
Invalidates the cache, preamble hasn't changed
- Read
builds AST using preamble v1, and caches it.
preamble for v2 gets build, cache isn't invalidated since preamble is same.
generateDiags tries to reuse cached AST but latest version is 3 not 2, so
assertion fails.
Reviewers: sammccall
Subscribers: ilya-biryukov, javed.absar, MaskRay, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D77664
Diffstat (limited to 'llvm/tools/llvm-objdump/llvm-objdump.cpp')
0 files changed, 0 insertions, 0 deletions