aboutsummaryrefslogtreecommitdiff
path: root/llvm/tools/llvm-objdump/llvm-objdump.cpp
diff options
context:
space:
mode:
authorYuanfang Chen <yuanfang.chen@sony.com>2019-06-22 00:22:57 +0000
committerYuanfang Chen <yuanfang.chen@sony.com>2019-06-22 00:22:57 +0000
commit0eb966c8248b290385980ffdad26553a520ace13 (patch)
tree177df341aa7fd45c1e8a16472d631e0d26065fdc /llvm/tools/llvm-objdump/llvm-objdump.cpp
parent4608868d2f4c074269fdb766c2d79c9513ed4ae9 (diff)
downloadllvm-0eb966c8248b290385980ffdad26553a520ace13.zip
llvm-0eb966c8248b290385980ffdad26553a520ace13.tar.gz
llvm-0eb966c8248b290385980ffdad26553a520ace13.tar.bz2
[llvm-objdump] Move --start-address >= --stop-address check out of the
-d code. Summary: Move it into `main` function so the checking is effective for all actions user may do with llvm-objdump; notably, -r and -s in addition to existing -d. Match GNU behavior. Reviewers: jhenderson, grimar, MaskRay, rupprecht Subscribers: llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D63631 llvm-svn: 364118
Diffstat (limited to 'llvm/tools/llvm-objdump/llvm-objdump.cpp')
-rw-r--r--llvm/tools/llvm-objdump/llvm-objdump.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp
index fc3acb4..23c25d5 100644
--- a/llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -1453,9 +1453,6 @@ static void disassembleObject(const Target *TheTarget, const ObjectFile *Obj,
}
static void disassembleObject(const ObjectFile *Obj, bool InlineRelocs) {
- if (StartAddress >= StopAddress)
- error("start address should be less than stop address");
-
const Target *TheTarget = getTarget(Obj);
// Package up features to be passed to target/subtarget
@@ -2116,6 +2113,9 @@ int main(int argc, char **argv) {
cl::ParseCommandLineOptions(argc, argv, "llvm object file dumper\n");
+ if (StartAddress >= StopAddress)
+ error("start address should be less than stop address");
+
ToolName = argv[0];
// Defaults to a.out if no filenames specified.