diff options
author | Michael Trent <mtrent@apple.com> | 2020-01-29 11:07:53 -0800 |
---|---|---|
committer | Michael Trent <mtrent@apple.com> | 2020-02-03 10:59:36 -0800 |
commit | 0ad18bf37b2d4f6a619f2ebdd6cfbe0ac617a2e5 (patch) | |
tree | 18d43f88205ac7ecd218a577bcc6f3cf4392599b /llvm/tools/llvm-objdump/llvm-objdump.cpp | |
parent | 3014efe071988724b67f2dc106d36002aa03fa7d (diff) | |
download | llvm-0ad18bf37b2d4f6a619f2ebdd6cfbe0ac617a2e5.zip llvm-0ad18bf37b2d4f6a619f2ebdd6cfbe0ac617a2e5.tar.gz llvm-0ad18bf37b2d4f6a619f2ebdd6cfbe0ac617a2e5.tar.bz2 |
[llvm-objdump] Suppress spurious warnings when parsing Mach-O binaries.
Summary:
llvm-objdump started warning when asked to disassemble a section that
isn't present in the input files, in Yuanfang Chen's change:
d16c162c9453db855503134fe29ae4a3c0bec936. The problem is that the
logic was restricted only to the generic llvm-objdump parser, not to the
Mach-O-specific parser used for Apple toolchain compatibility. The
solution is to log section names from the Mach-O parser.
The macho-cstring-dump.test has been updated to fail if it encounters
this new warning in the future.
Reviewers: pete, ab, lhames, jhenderson, grimar, MaskRay, ychen
Reviewed By: jhenderson, grimar
Subscribers: rupprecht, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D73586
Diffstat (limited to 'llvm/tools/llvm-objdump/llvm-objdump.cpp')
-rw-r--r-- | llvm/tools/llvm-objdump/llvm-objdump.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp index 6c95d36..dc8a4b7 100644 --- a/llvm/tools/llvm-objdump/llvm-objdump.cpp +++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp @@ -338,7 +338,7 @@ static cl::extrahelp HelpResponse("\nPass @FILE as argument to read options from FILE.\n"); static StringSet<> DisasmFuncsSet; -static StringSet<> FoundSectionSet; +StringSet<> FoundSectionSet; static StringRef ToolName; typedef std::vector<std::tuple<uint64_t, StringRef, uint8_t>> SectionSymbolsTy; |