aboutsummaryrefslogtreecommitdiff
path: root/llvm/tools/llvm-objcopy/llvm-objcopy.cpp
diff options
context:
space:
mode:
authorserge-sans-paille <sguelton@mozilla.com>2023-01-04 08:28:45 +0100
committerserge-sans-paille <sguelton@mozilla.com>2023-01-05 14:11:08 +0100
commit38818b60c58c76ba89b990978cdfd2d7b6799260 (patch)
tree63c85a12b00f87ec07dd8ad566970361e88f6fa4 /llvm/tools/llvm-objcopy/llvm-objcopy.cpp
parent11be5cc00110eaff473cd41714120a11878326fc (diff)
downloadllvm-38818b60c58c76ba89b990978cdfd2d7b6799260.zip
llvm-38818b60c58c76ba89b990978cdfd2d7b6799260.tar.gz
llvm-38818b60c58c76ba89b990978cdfd2d7b6799260.tar.bz2
Move from llvm::makeArrayRef to ArrayRef deduction guides - llvm/ part
Use deduction guides instead of helper functions. The only non-automatic changes have been: 1. ArrayRef(some_uint8_pointer, 0) needs to be changed into ArrayRef(some_uint8_pointer, (size_t)0) to avoid an ambiguous call with ArrayRef((uint8_t*), (uint8_t*)) 2. CVSymbol sym(makeArrayRef(symStorage)); needed to be rewritten as CVSymbol sym{ArrayRef(symStorage)}; otherwise the compiler is confused and thinks we have a (bad) function prototype. There was a few similar situation across the codebase. 3. ADL doesn't seem to work the same for deduction-guides and functions, so at some point the llvm namespace must be explicitly stated. 4. The "reference mode" of makeArrayRef(ArrayRef<T> &) that acts as no-op is not supported (a constructor cannot achieve that). Per reviewers' comment, some useless makeArrayRef have been removed in the process. This is a follow-up to https://reviews.llvm.org/D140896 that introduced the deduction guides. Differential Revision: https://reviews.llvm.org/D140955
Diffstat (limited to 'llvm/tools/llvm-objcopy/llvm-objcopy.cpp')
-rw-r--r--llvm/tools/llvm-objcopy/llvm-objcopy.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/tools/llvm-objcopy/llvm-objcopy.cpp b/llvm/tools/llvm-objcopy/llvm-objcopy.cpp
index aa26215..a24cd88 100644
--- a/llvm/tools/llvm-objcopy/llvm-objcopy.cpp
+++ b/llvm/tools/llvm-objcopy/llvm-objcopy.cpp
@@ -240,7 +240,7 @@ int llvm_objcopy_main(int argc, char **argv) {
: cl::TokenizeGNUCommandLine,
NewArgv);
- auto Args = makeArrayRef(NewArgv).drop_front();
+ auto Args = ArrayRef(NewArgv).drop_front();
Expected<DriverConfig> DriverConfig = getDriverConfig(Args);
if (!DriverConfig) {