aboutsummaryrefslogtreecommitdiff
path: root/llvm/tools/llvm-cov/CodeCoverage.cpp
diff options
context:
space:
mode:
authorserge-sans-paille <sguelton@redhat.com>2022-10-13 10:26:41 +0200
committerserge-sans-paille <serge.guelton@telecom-bretagne.eu>2022-10-14 22:34:17 +0200
commit232e0a011e8c07053bdc0156f312046eb09f52b3 (patch)
tree181809e710161ddd53314af008a3b20360959a31 /llvm/tools/llvm-cov/CodeCoverage.cpp
parent0c8dde551c801f319271fe662e82fef462dd07e0 (diff)
downloadllvm-232e0a011e8c07053bdc0156f312046eb09f52b3.zip
llvm-232e0a011e8c07053bdc0156f312046eb09f52b3.tar.gz
llvm-232e0a011e8c07053bdc0156f312046eb09f52b3.tar.bz2
[lto] Do not try to internalize symbols with escaped name
Because of LLVM mangling escape sequence (through '\01' prefix), it is possible for a single symbols two have two different IR representations. For instance, consider @symbol and @"\01_symbol". On OSX, because of the system mangling rules, these two IR names point are converted in the same final symbol upon linkage. LTO doesn't model this behavior, which may result in symbols being incorrectly internalized (if all reference use the escaping sequence while the definition doesn't). The proper approach is probably to use the mangled name to compute GUID to avoid the dual representation, but we can also avoid discarding symbols that are bound to two different IR names. This is an approximation, but it's less intrusive on the codebase. Fix #57864 Differential Revision: https://reviews.llvm.org/D135710
Diffstat (limited to 'llvm/tools/llvm-cov/CodeCoverage.cpp')
0 files changed, 0 insertions, 0 deletions