diff options
| author | goldsteinn <35538541+goldsteinn@users.noreply.github.com> | 2024-10-17 11:32:55 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-10-17 10:32:55 -0500 |
| commit | c85611e8583e6392d56075ebdfa60893b6284813 (patch) | |
| tree | 0e9755aaff4332c655e985d957f821faca52661f /llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp | |
| parent | ab208de34efbde4fea03732eaa353a701e72f626 (diff) | |
| download | llvm-c85611e8583e6392d56075ebdfa60893b6284813.zip llvm-c85611e8583e6392d56075ebdfa60893b6284813.tar.gz llvm-c85611e8583e6392d56075ebdfa60893b6284813.tar.bz2 | |
[SimplifyLibCall][Attribute] Fix bug where we may keep `range` attr with incompatible type (#112649)
In a variety of places we change the bitwidth of a parameter but don't
update the attributes.
The issue in this case is from the `range` attribute when inlining
`__memset_chk`. `optimizeMemSetChk` will replace an `i32` with an
`i8`, and if the `i32` had a `range` attr assosiated it will cause an
error.
Fixes #112633
Diffstat (limited to 'llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp')
| -rw-r--r-- | llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp b/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp index cb4ef87..79e91ad 100644 --- a/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp +++ b/llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp @@ -342,7 +342,13 @@ static Value *copyFlags(const CallInst &Old, Value *New) { static Value *mergeAttributesAndFlags(CallInst *NewCI, const CallInst &Old) { NewCI->setAttributes(AttributeList::get( NewCI->getContext(), {NewCI->getAttributes(), Old.getAttributes()})); - NewCI->removeRetAttrs(AttributeFuncs::typeIncompatible(NewCI->getType())); + NewCI->removeRetAttrs(AttributeFuncs::typeIncompatible( + NewCI->getType(), NewCI->getRetAttributes())); + for (unsigned I = 0; I < NewCI->arg_size(); ++I) + NewCI->removeParamAttrs( + I, AttributeFuncs::typeIncompatible(NewCI->getArgOperand(I)->getType(), + NewCI->getParamAttributes(I))); + return copyFlags(Old, NewCI); } |