diff options
| author | Jonas Devlieghere <jonas@devlieghere.com> | 2021-02-17 09:30:07 -0800 |
|---|---|---|
| committer | Jonas Devlieghere <jonas@devlieghere.com> | 2021-02-17 10:00:29 -0800 |
| commit | d6e80578fc5e5199d5783671bd0c8ce1050925f9 (patch) | |
| tree | 7edc5481d67e52742ef878511b9269b64f036294 /llvm/lib/Transforms/Utils/SampleProfileLoaderBaseUtil.cpp | |
| parent | 8a783e68452f646360d9902d2c2bc0e115d7bfa9 (diff) | |
| download | llvm-d6e80578fc5e5199d5783671bd0c8ce1050925f9.zip llvm-d6e80578fc5e5199d5783671bd0c8ce1050925f9.tar.gz llvm-d6e80578fc5e5199d5783671bd0c8ce1050925f9.tar.bz2 | |
[lldb] Improve error message for modules with dots or dashes
LLDB does not like to import Python files with dashes or dots in their
name. While the former are technically allowed, it is discouraged. Dots
are allowed for subpackages but not in module names. This patch improves
the user experience by printing a useful error.
Before this patch:
error: module importing failed: SyntaxError('invalid syntax',
('<string>', 1, 11, 'import foo-bar\n'))
After this patch:
error: module importing failed: Python discourages dashes in module
names: foo-bar
rdar://74263511
[1] https://www.python.org/dev/peps/pep-0008/#package-and-module-names
Differential revision: https://reviews.llvm.org/D96833
Diffstat (limited to 'llvm/lib/Transforms/Utils/SampleProfileLoaderBaseUtil.cpp')
0 files changed, 0 insertions, 0 deletions