aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/Transforms/Utils/ModuleUtils.cpp
diff options
context:
space:
mode:
authorJordan Rupprecht <rupprecht@google.com>2019-01-31 16:45:16 +0000
committerJordan Rupprecht <rupprecht@google.com>2019-01-31 16:45:16 +0000
commitbd7735f79765e826c23d48d23c0ad327c9393f90 (patch)
tree1a6431176e26cd058bb9bc13ad9bfe4b98e7ad93 /llvm/lib/Transforms/Utils/ModuleUtils.cpp
parent6fa5e62c25f4523ab62ec0265afc3917b9d6c16b (diff)
downloadllvm-bd7735f79765e826c23d48d23c0ad327c9393f90.zip
llvm-bd7735f79765e826c23d48d23c0ad327c9393f90.tar.gz
llvm-bd7735f79765e826c23d48d23c0ad327c9393f90.tar.bz2
[llvm-objcopy] Skip --localize-symbol for undefined symbols
Summary: Include the symbol being defined in the list of requirements for using --localize-symbol. This is used, for example, when someone is depending on two different projects that have the same (or close enough) method defined in each library, and using "-L sym" for a conflicting symbol in one of the libraries so that the definition from the other one is used. However, the library may have internal references to the symbol, which cause program crashes when those are used, i.e.: ``` $ cat foo.c int foo() { return 5; } $ cat bar.c int foo(); int bar() { return 2 * foo(); } $ cat foo2.c int foo() { /* Safer implementation */ return 42; } $ cat main.c int bar(); int main() { __builtin_printf("bar = %d\n", bar()); return 0; } $ ar rcs libfoo.a foo.o bar.o $ ar rcs libfoo2.a foo2.o # Picks the wrong foo() impl $ clang main.o -lfoo -lfoo2 -L. -o main # Picks the right foo() impl $ objcopy -L foo libfoo.a && clang main.o -lfoo -lfoo2 -L. -o main # Links somehow, but crashes at runtime $ llvm-objcopy -L foo libfoo.a && clang main.o -lfoo -lfoo2 -L. -o main ``` Reviewers: jhenderson, alexshap, jakehehrlich, espindola Subscribers: emaste, arichardson Differential Revision: https://reviews.llvm.org/D57417 llvm-svn: 352767
Diffstat (limited to 'llvm/lib/Transforms/Utils/ModuleUtils.cpp')
0 files changed, 0 insertions, 0 deletions