diff options
author | Michael Buch <michaelbuch12@gmail.com> | 2022-09-22 16:17:31 +0200 |
---|---|---|
committer | Michael Buch <michaelbuch12@gmail.com> | 2022-09-23 12:27:08 +0200 |
commit | d5d90428500870107909fb8f90023ff608cd1ec2 (patch) | |
tree | 8f277f649991401ce8eb683f29f102724d30bd6a /llvm/lib/Transforms/Utils/LoopVersioning.cpp | |
parent | 6c6b48434ed85841f147c789a96a309e1fff16ae (diff) | |
download | llvm-d5d90428500870107909fb8f90023ff608cd1ec2.zip llvm-d5d90428500870107909fb8f90023ff608cd1ec2.tar.gz llvm-d5d90428500870107909fb8f90023ff608cd1ec2.tar.bz2 |
[lldb][TypeSystemClang] Deduce lldb::eEncodingUint for unsigned enum types
The motivating issue was the following:
```
$ cat main.cpp
enum class EnumVals : uint16_t {
VAL1 = 0
};
struct Foo {
EnumVals b1 : 4;
};
int main() {
// Assign value out-of-range if
// bit-field were signed
Foo f{.b1 = (EnumVals)8};
return 0; // Break here
}
(lldb) script
>>> lldb.frame.FindVariable("f").GetChildMemberWithName("b1").GetValueAsUnsigned()
4294967288
```
In the above example we observe a unsigned integer wrap-around
because we sign-extended the bit-fields underlying Scalar value
before casting it to an unsigned. The sign extension occurs because
we don't mark APSInt::IsUnsigned == true correctly when extracting
the value from memory (in Value::ResolveValue). The reason why sign
extension causes the wraparound is that the value we're assigning
to the bit-field is out-of-range (if it were a signed bit-field),
which causes `Scalar::sext` to left-fill the Scalar with 1s.
This patch corrects GetEncoding to account for unsigned enum types.
With this change the Scalar would be zero-extended instead.
This is mainly a convenience fix which well-formed code wouldn't
encounter.
rdar://99785324
Differential Revision: https://reviews.llvm.org/D134493
Diffstat (limited to 'llvm/lib/Transforms/Utils/LoopVersioning.cpp')
0 files changed, 0 insertions, 0 deletions