diff options
author | Andrew Rogers <andrurogerz@gmail.com> | 2025-06-11 09:19:13 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-06-11 09:19:13 -0700 |
commit | 8f8ed23c6247e9c1dd2df4494930813b353c52c4 (patch) | |
tree | f7ae639cd70d7bb2f36dd4a970238480615c333d /llvm/lib/Transforms/Utils/LoopUtils.cpp | |
parent | 5188bea9afac859fa6523e07d98748527c295aaf (diff) | |
download | llvm-8f8ed23c6247e9c1dd2df4494930813b353c52c4.zip llvm-8f8ed23c6247e9c1dd2df4494930813b353c52c4.tar.gz llvm-8f8ed23c6247e9c1dd2df4494930813b353c52c4.tar.bz2 |
[llvm] annotate interfaces in llvm/SandboxIR for DLL export (#142863)
## Purpose
This patch is one in a series of code-mods that annotate LLVM’s public
interface for export. This patch annotates the `llvm/SandboxIR` library.
These annotations currently have no meaningful impact on the LLVM build;
however, they are a prerequisite to support an LLVM Windows DLL (shared
library) build.
## Background
This effort is tracked in #109483. Additional context is provided in
[this
discourse](https://discourse.llvm.org/t/psa-annotating-llvm-public-interface/85307),
and documentation for `LLVM_ABI` and related annotations is found in the
LLVM repo
[here](https://github.com/llvm/llvm-project/blob/main/llvm/docs/InterfaceExportAnnotations.rst).
The bulk of these changes were generated automatically using the
[Interface Definition Scanner (IDS)](https://github.com/compnerd/ids)
tool, followed formatting with `git clang-format`.
The following manual adjustments were also applied after running IDS on
Linux:
- Remove explicit `GlobalWithNodeAPI::LLVMGVToGV::operator()` template
function instantiations that were previously added for the dylib build.
Instead, directly annotate the `LLVMGVToGV::operator()` method with
`LLVM_ABI`. This is done so the DLL build works with both MSVC and
clang-cl.
- Explicitly `#include "llvm/SandboxIR/Value.h"` in `Tracker.h` so that
the symbol is available for exported templates in this file. These
templates get fully instantiated on DLL export, so they require the full
definition of `Value`.
- Add extern template instantiation declarations for `GlobalWithNodeAPI`
template types in `Constants.h` and annotate them with
`LLVM_TEMPLATE_ABI`.
- Add `LLVM_EXPORT_TEMPLATE` to `GlobalWithNodeAPI` template
instantiations in `Constants.cpp`.
## Validation
Local builds and tests to validate cross-platform compatibility. This
included llvm, clang, and lldb on the following configurations:
- Windows with MSVC
- Windows with Clang
- Linux with GCC
- Linux with Clang
- Darwin with Clang
Diffstat (limited to 'llvm/lib/Transforms/Utils/LoopUtils.cpp')
0 files changed, 0 insertions, 0 deletions