diff options
author | Kazu Hirata <kazu@google.com> | 2024-05-04 12:33:12 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-05-04 12:33:12 -0700 |
commit | 677dddebae77a93e080a98617aa2714be4a46fd0 (patch) | |
tree | 3c9f6de6a0904eded90f4f94f13fc1fec62e297b /llvm/lib/Transforms/Utils/LoopUtils.cpp | |
parent | 24f5fc77d43f4ae2dc1cb0c0902c5e22cbadf09e (diff) | |
download | llvm-677dddebae77a93e080a98617aa2714be4a46fd0.zip llvm-677dddebae77a93e080a98617aa2714be4a46fd0.tar.gz llvm-677dddebae77a93e080a98617aa2714be4a46fd0.tar.bz2 |
[Transforms] Use StringRef::operator== instead of StringRef::equals (NFC) (#91072)
I'm planning to remove StringRef::equals in favor of
StringRef::operator==.
- StringRef::operator==/!= outnumber StringRef::equals by a factor of
31 under llvm/ in terms of their usage.
- The elimination of StringRef::equals brings StringRef closer to
std::string_view, which has operator== but not equals.
- S == "foo" is more readable than S.equals("foo"), especially for
!Long.Expression.equals("str") vs Long.Expression != "str".
Diffstat (limited to 'llvm/lib/Transforms/Utils/LoopUtils.cpp')
-rw-r--r-- | llvm/lib/Transforms/Utils/LoopUtils.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/Transforms/Utils/LoopUtils.cpp b/llvm/lib/Transforms/Utils/LoopUtils.cpp index f783b70..cc883a7 100644 --- a/llvm/lib/Transforms/Utils/LoopUtils.cpp +++ b/llvm/lib/Transforms/Utils/LoopUtils.cpp @@ -222,7 +222,7 @@ void llvm::addStringMetadataToLoop(Loop *TheLoop, const char *StringMD, // If it is of form key = value, try to parse it. if (Node->getNumOperands() == 2) { MDString *S = dyn_cast<MDString>(Node->getOperand(0)); - if (S && S->getString().equals(StringMD)) { + if (S && S->getString() == StringMD) { ConstantInt *IntMD = mdconst::extract_or_null<ConstantInt>(Node->getOperand(1)); if (IntMD && IntMD->getSExtValue() == V) |