diff options
author | Fangrui Song <i@maskray.me> | 2021-06-04 13:27:56 -0700 |
---|---|---|
committer | Fangrui Song <i@maskray.me> | 2021-06-04 13:27:56 -0700 |
commit | 9e51d1f348b95affe6a8345ce3906997a49f0297 (patch) | |
tree | f36bdfa942b814f587ec5e011d31e8cd78f6a9ef /llvm/lib/Transforms/Utils/LoopRotationUtils.cpp | |
parent | ca68f3bc48e48f839142de1461e95d87ae48e9df (diff) | |
download | llvm-9e51d1f348b95affe6a8345ce3906997a49f0297.zip llvm-9e51d1f348b95affe6a8345ce3906997a49f0297.tar.gz llvm-9e51d1f348b95affe6a8345ce3906997a49f0297.tar.bz2 |
[InstrProfiling] If no value profiling, make data variable private and (for Windows) use one comdat
`__profd_*` variables are referenced by code only when value profiling is
enabled. If disabled (e.g. default -fprofile-instr-generate), the symbols just
waste space on ELF/Mach-O. We change the comdat symbol from `__profd_*` to
`__profc_*` because an internal symbol does not provide deduplication features
on COFF. The choice doesn't matter on ELF.
(In -DLLVM_BUILD_INSTRUMENTED_COVERAGE=on build, there is now no `__profd_*` symbols.)
On Windows this enables further optimization. We are no longer affected by the
link.exe limitation: an external symbol in IMAGE_COMDAT_SELECT_ASSOCIATIVE can
cause duplicate definition error.
https://lists.llvm.org/pipermail/llvm-dev/2021-May/150758.html
We can thus use llvm.compiler.used instead of llvm.used like ELF (D97585).
This avoids many `/INCLUDE:` directives in `.drectve`.
Here is rnk's measurement for Chrome:
```
This reduced object file size of base_unittests.exe, compiled with coverage, optimizations, and gmlt debug info by 10%:
#BEFORE
$ find . -iname '*.obj' | xargs du -b | awk '{ sum += $1 } END { print sum}'
1047758867
$ du -cksh base_unittests.exe
82M base_unittests.exe
82M total
# AFTER
$ find . -iname '*.obj' | xargs du -b | awk '{ sum += $1 } END { print sum}'
937886499
$ du -cksh base_unittests.exe
78M base_unittests.exe
78M total
```
The change is NFC for Mach-O.
Reviewed By: davidxl, rnk
Differential Revision: https://reviews.llvm.org/D103372
Diffstat (limited to 'llvm/lib/Transforms/Utils/LoopRotationUtils.cpp')
0 files changed, 0 insertions, 0 deletions