diff options
author | Chijun Sima <simachijun@gmail.com> | 2018-08-04 08:13:47 +0000 |
---|---|---|
committer | Chijun Sima <simachijun@gmail.com> | 2018-08-04 08:13:47 +0000 |
commit | 8b5de48d62872ce16848fd9f207faf904b8d1c0e (patch) | |
tree | b408d6eb0237e3e8824d86cb361d6ec212e6f6c2 /llvm/lib/Transforms/Utils/LoopRotationUtils.cpp | |
parent | 03b4d0c19fbbe78e804bc12b069a9060d5c72430 (diff) | |
download | llvm-8b5de48d62872ce16848fd9f207faf904b8d1c0e.zip llvm-8b5de48d62872ce16848fd9f207faf904b8d1c0e.tar.gz llvm-8b5de48d62872ce16848fd9f207faf904b8d1c0e.tar.bz2 |
[TailCallElim] Preserve DT and PDT
Summary:
Previously, in the NewPM pipeline, TailCallElim recalculates the DomTree when it modifies any instruction in the Function.
For example,
```
CallInst *CI = dyn_cast<CallInst>(&I);
...
CI->setTailCall();
Modified = true;
...
if (!Modified || ...)
return PreservedAnalyses::all();
```
After applying this patch, the DomTree only recalculates if needed (plus an extra insertEdge() + an extra deleteEdge() call).
When optimizing SQLite with `-passes="default<O3>"` pipeline of the newPM, the number of DomTree recalculation decreases by 6.2%, the number of nodes visited by DFS decreases by 2.9%. The time used by DomTree will decrease approximately 1%~2.5% after applying the patch.
Statistics:
```
Before the patch:
23010 dom-tree-stats - Number of DomTree recalculations
489264 dom-tree-stats - Number of nodes visited by DFS -- DomTree
After the patch:
21581 dom-tree-stats - Number of DomTree recalculations
475088 dom-tree-stats - Number of nodes visited by DFS -- DomTree
```
Reviewers: kuhar, dmgreen, brzycki, grosser, davide
Reviewed By: kuhar, brzycki
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D49982
llvm-svn: 338954
Diffstat (limited to 'llvm/lib/Transforms/Utils/LoopRotationUtils.cpp')
0 files changed, 0 insertions, 0 deletions