diff options
| author | Raphael Isemann <teemperor@gmail.com> | 2021-05-26 17:52:51 +0200 |
|---|---|---|
| committer | Raphael Isemann <teemperor@gmail.com> | 2021-05-26 18:27:40 +0200 |
| commit | d28bc54ff44aad7b080177ef85764d7c5444f031 (patch) | |
| tree | 0ac83eca91d3b17093c7beec0a04198c368f6cbd /llvm/lib/Transforms/Utils/Local.cpp | |
| parent | 1b47a3de48d2ac3ee4420209ab5d191f66849979 (diff) | |
| download | llvm-d28bc54ff44aad7b080177ef85764d7c5444f031.zip llvm-d28bc54ff44aad7b080177ef85764d7c5444f031.tar.gz llvm-d28bc54ff44aad7b080177ef85764d7c5444f031.tar.bz2 | |
[lldb] Remove cache in get_demangled_name_without_arguments
This function has a single-value caching based on function local static variables.
This causes two problems:
* There is no synchronization, so this function randomly returns the demangled
name of other functions that are demangled at the same time.
* The 1-element cache is not very effective (the cache rate is around 0% when
running the LLDB test suite that calls this function around 30k times).
I would propose just removing it.
To prevent anyone else the git archeology: the static result variables were
originally added as this returned a ConstString reference, but that has since
been changed so that this returns by value.
Reviewed By: #lldb, JDevlieghere, shafik
Differential Revision: https://reviews.llvm.org/D103107
Diffstat (limited to 'llvm/lib/Transforms/Utils/Local.cpp')
0 files changed, 0 insertions, 0 deletions