diff options
author | Serge Pavlov <sepavloff@gmail.com> | 2019-11-01 20:49:35 +0700 |
---|---|---|
committer | Serge Pavlov <sepavloff@gmail.com> | 2022-03-31 19:15:52 +0700 |
commit | 47b3b76825dc89d4ee37408f26b458f61f86fbf5 (patch) | |
tree | 5e6584bf65150bfeea7a45d09fb485633d3327eb /llvm/lib/Transforms/Utils/InlineFunction.cpp | |
parent | b4417075dc1cbfac0a3f777850ba77c031d7db3c (diff) | |
download | llvm-47b3b76825dc89d4ee37408f26b458f61f86fbf5.zip llvm-47b3b76825dc89d4ee37408f26b458f61f86fbf5.tar.gz llvm-47b3b76825dc89d4ee37408f26b458f61f86fbf5.tar.bz2 |
Implement inlining of strictfp functions
According to the current design, if a floating point operation is
represented by a constrained intrinsic somewhere in a function, all
floating point operations in the function must be represented by
constrained intrinsics. It imposes additional requirements to inlining
mechanism. If non-strictfp function is inlined into strictfp function,
all ordinary FP operations must be replaced with their constrained
counterparts.
Inlining strictfp function into non-strictfp is not implemented as it
would require replacement of all FP operations in the host function,
which now is undesirable due to expected performance loss.
Differential Revision: https://reviews.llvm.org/D69798
Diffstat (limited to 'llvm/lib/Transforms/Utils/InlineFunction.cpp')
-rw-r--r-- | llvm/lib/Transforms/Utils/InlineFunction.cpp | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/llvm/lib/Transforms/Utils/InlineFunction.cpp b/llvm/lib/Transforms/Utils/InlineFunction.cpp index e0ae69a..a861696 100644 --- a/llvm/lib/Transforms/Utils/InlineFunction.cpp +++ b/llvm/lib/Transforms/Utils/InlineFunction.cpp @@ -1788,6 +1788,13 @@ llvm::InlineResult llvm::InlineFunction(CallBase &CB, InlineFunctionInfo &IFI, BasicBlock *OrigBB = CB.getParent(); Function *Caller = OrigBB->getParent(); + // Do not inline strictfp function into non-strictfp one. It would require + // conversion of all FP operations in host function to constrained intrinsics. + if (CalledFunc->getAttributes().hasFnAttr(Attribute::StrictFP) && + !Caller->getAttributes().hasFnAttr(Attribute::StrictFP)) { + return InlineResult::failure("incompatible strictfp attributes"); + } + // GC poses two hazards to inlining, which only occur when the callee has GC: // 1. If the caller has no GC, then the callee's GC must be propagated to the // caller. |