diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2015-01-19 21:11:14 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2015-01-19 21:11:14 +0000 |
commit | 2658554aeca02328bcd0ee9ca80d902e0a107563 (patch) | |
tree | 4f747f8540f2396f5a38a127f388fdd2f95b57d3 /llvm/lib/Transforms/Utils/InlineFunction.cpp | |
parent | 799e56a9ae40adb682d7cd2b9a69e0e3a2802977 (diff) | |
download | llvm-2658554aeca02328bcd0ee9ca80d902e0a107563.zip llvm-2658554aeca02328bcd0ee9ca80d902e0a107563.tar.gz llvm-2658554aeca02328bcd0ee9ca80d902e0a107563.tar.bz2 |
Add r224985 back with fixes.
The fixes are to note that AArch64 has additional restrictions on when local
relocations can be used. In particular, ld64 requires that relocations to
cstring/cfstrings use linker visible symbols.
Original message:
In an assembly expression like
bar:
.long L0 + 1
the intended semantics is that bar will contain a pointer one byte past L0.
In sections that are merged by content (strings, 4 byte constants, etc), a
single position in the section doesn't give the linker enough information.
For example, it would not be able to tell a relocation must point to the
end of a string, since that would look just like the start of the next.
The solution used in ELF to use relocation with symbols if there is a non-zero
addend.
In MachO before this patch we would just keep all symbols in some sections.
This would miss some cases (only cstrings on x86_64 were implemented) and was
inefficient since most relocations have an addend of 0 and can be represented
without the symbol.
This patch implements the non-zero addend logic for MachO too.
llvm-svn: 226503
Diffstat (limited to 'llvm/lib/Transforms/Utils/InlineFunction.cpp')
0 files changed, 0 insertions, 0 deletions