diff options
author | Adrian Prantl <aprantl@apple.com> | 2024-09-18 14:54:49 -0700 |
---|---|---|
committer | Adrian Prantl <aprantl@apple.com> | 2024-09-23 14:33:41 -0700 |
commit | 1fae1314f1ff58f3601640c0a2c48cee3a322e5d (patch) | |
tree | 8360f66286d25728934f2f94717b34a34b94c427 /llvm/lib/Transforms/Utils/InlineFunction.cpp | |
parent | 3bbe0f90f33357c27e3195207fa35c0fb44e426c (diff) | |
download | llvm-1fae1314f1ff58f3601640c0a2c48cee3a322e5d.zip llvm-1fae1314f1ff58f3601640c0a2c48cee3a322e5d.tar.gz llvm-1fae1314f1ff58f3601640c0a2c48cee3a322e5d.tar.bz2 |
[lldb] Change the implementation of Status to store an llvm::Error (NFC) (#106774)
(based on a conversation I had with @labath yesterday in
https://github.com/llvm/llvm-project/pull/106442)
Most APIs that currently vend a Status would be better served by
returning llvm::Expected<> instead. If possibles APIs should be
refactored to avoid Status. The only legitimate long-term uses of Status
are objects that need to store an error for a long time (which should be
questioned as a design decision, too).
This patch makes the transition to llvm::Error easier by making the
places that cannot switch to llvm::Error explicit: They are marked with
a call to Status::clone(). Every other API can and should be refactored
to use llvm::Expected. In the end Status should only be used in very few
places.
Whenever an unchecked Error is dropped by Status it logs this to the
verbose API channel.
Implementation notes:
This patch introduces two new kinds of error_category as well as new
llvm::Error types. Here is the mapping of lldb::ErrorType to
llvm::Errors:
```
(eErrorTypeInvalid)
eErrorTypeGeneric llvm::StringError
eErrorTypePOSIX llvm::ECError
eErrorTypeMachKernel MachKernelError
eErrorTypeExpression llvm::ErrorList<ExpressionError>
eErrorTypeWin32 Win32Error
```
Relanding with built-in cloning support for llvm::ECError, and support
for initializing a Windows error with a NO_ERROR error code, and
modifying TestGDBRemotePlatformFile.py to support different renderings
of ENOSYS.
Diffstat (limited to 'llvm/lib/Transforms/Utils/InlineFunction.cpp')
0 files changed, 0 insertions, 0 deletions