diff options
| author | goldsteinn <35538541+goldsteinn@users.noreply.github.com> | 2024-10-17 11:32:55 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-10-17 10:32:55 -0500 |
| commit | c85611e8583e6392d56075ebdfa60893b6284813 (patch) | |
| tree | 0e9755aaff4332c655e985d957f821faca52661f /llvm/lib/Transforms/Utils/CloneFunction.cpp | |
| parent | ab208de34efbde4fea03732eaa353a701e72f626 (diff) | |
| download | llvm-c85611e8583e6392d56075ebdfa60893b6284813.zip llvm-c85611e8583e6392d56075ebdfa60893b6284813.tar.gz llvm-c85611e8583e6392d56075ebdfa60893b6284813.tar.bz2 | |
[SimplifyLibCall][Attribute] Fix bug where we may keep `range` attr with incompatible type (#112649)
In a variety of places we change the bitwidth of a parameter but don't
update the attributes.
The issue in this case is from the `range` attribute when inlining
`__memset_chk`. `optimizeMemSetChk` will replace an `i32` with an
`i8`, and if the `i32` had a `range` attr assosiated it will cause an
error.
Fixes #112633
Diffstat (limited to 'llvm/lib/Transforms/Utils/CloneFunction.cpp')
| -rw-r--r-- | llvm/lib/Transforms/Utils/CloneFunction.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/Transforms/Utils/CloneFunction.cpp b/llvm/lib/Transforms/Utils/CloneFunction.cpp index c6ba85b..5dc82a8 100644 --- a/llvm/lib/Transforms/Utils/CloneFunction.cpp +++ b/llvm/lib/Transforms/Utils/CloneFunction.cpp @@ -819,9 +819,9 @@ void llvm::CloneAndPruneIntoFromInst(Function *NewFunc, const Function *OldFunc, // Drop all incompatible return attributes that cannot be applied to NewFunc // during cloning, so as to allow instruction simplification to reason on the // old state of the function. The original attributes are restored later. - AttributeMask IncompatibleAttrs = - AttributeFuncs::typeIncompatible(OldFunc->getReturnType()); AttributeList Attrs = NewFunc->getAttributes(); + AttributeMask IncompatibleAttrs = AttributeFuncs::typeIncompatible( + OldFunc->getReturnType(), Attrs.getRetAttrs()); NewFunc->removeRetAttrs(IncompatibleAttrs); // As phi-nodes have been now remapped, allow incremental simplification of |