diff options
| author | Pavel Labath <pavel@labath.sk> | 2020-07-15 17:13:20 +0200 |
|---|---|---|
| committer | Pavel Labath <pavel@labath.sk> | 2020-07-17 13:24:59 +0200 |
| commit | ede7c02b38c0c3adf7fb9ee308bd0f6d92a0eb4e (patch) | |
| tree | 88fed19aa0eeb063f55f1c7599849a8417306a70 /llvm/lib/Transforms/Utils/BasicBlockUtils.cpp | |
| parent | 6c348e4067b0826449caef2f77af2fb67c27040a (diff) | |
| download | llvm-ede7c02b38c0c3adf7fb9ee308bd0f6d92a0eb4e.zip llvm-ede7c02b38c0c3adf7fb9ee308bd0f6d92a0eb4e.tar.gz llvm-ede7c02b38c0c3adf7fb9ee308bd0f6d92a0eb4e.tar.bz2 | |
[lldb/COFF] Remove strtab zeroing hack
Summary:
This code (recently responsible for a unaligned access sanitizer
failure) claims that the string table offset zero should result in an
empty string.
I cannot find any mention of this detail in the Microsoft COFF
documentation, and the llvm COFF parser also does not handle offset zero
specially. This code was introduced in 0076e7159, which also does not go
into specifics, citing "various bugfixes".
Given that this is obviously a hack, and does not cause tests to fail, I
think we should just delete it.
Reviewers: amccarth, markmentovai
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D83881
Diffstat (limited to 'llvm/lib/Transforms/Utils/BasicBlockUtils.cpp')
0 files changed, 0 insertions, 0 deletions