diff options
| author | Uday Bondhugula <uday@polymagelabs.com> | 2021-03-25 16:53:45 +0530 |
|---|---|---|
| committer | Uday Bondhugula <uday@polymagelabs.com> | 2021-03-25 22:17:26 +0530 |
| commit | 0b20413ef6717d914a8b8a9ece86d8eae27c221f (patch) | |
| tree | 0b7b1fd3307c7ee551f7bd46ef73fe6c6eb3bc56 /llvm/lib/Transforms/Utils/BasicBlockUtils.cpp | |
| parent | d97189600e26553fa4fcdc73bd66b22c0ea420dd (diff) | |
| download | llvm-0b20413ef6717d914a8b8a9ece86d8eae27c221f.zip llvm-0b20413ef6717d914a8b8a9ece86d8eae27c221f.tar.gz llvm-0b20413ef6717d914a8b8a9ece86d8eae27c221f.tar.bz2 | |
Revert "[Canonicalizer] Process regions top-down instead of bottom up & reuse existing constants."
This reverts commit 361b7d125b438cda13fa45f13790767a62252be9 by Chris
Lattner <clattner@nondot.org> dated Fri Mar 19 21:22:15 2021 -0700.
The change to the greedy rewriter driver picking a different order was
made without adequate analysis of the trade-offs and experimentation. A
change like this has far reaching consequences on transformation
pipelines, and a major impact upstream and downstream. For eg., one
can’t be sure that it doesn’t slow down a large number of cases by small
amounts or create other issues. More discussion here:
https://llvm.discourse.group/t/speeding-up-canonicalize/3015/25
Reverting this so that improvements to the traversal order can be made
on a clean slate, in bigger steps, and higher bar.
Differential Revision: https://reviews.llvm.org/D99329
Diffstat (limited to 'llvm/lib/Transforms/Utils/BasicBlockUtils.cpp')
0 files changed, 0 insertions, 0 deletions