diff options
author | David Majnemer <david.majnemer@gmail.com> | 2016-05-03 03:57:40 +0000 |
---|---|---|
committer | David Majnemer <david.majnemer@gmail.com> | 2016-05-03 03:57:40 +0000 |
commit | 3d90bb79c4e81dfd76afe26a771097dc3852674c (patch) | |
tree | d3dc2a6f76ce26012d6976cc9618d9df5afbca2c /llvm/lib/Transforms/Scalar/LoopUnswitch.cpp | |
parent | 2a4c00f24328cece37ee57134974b24e4295a17e (diff) | |
download | llvm-3d90bb79c4e81dfd76afe26a771097dc3852674c.zip llvm-3d90bb79c4e81dfd76afe26a771097dc3852674c.tar.gz llvm-3d90bb79c4e81dfd76afe26a771097dc3852674c.tar.bz2 |
[LoopUnroll] Unroll loops which have exit blocks to EH pads
We were overly cautious in our analysis of loops which have invokes
which unwind to EH pads. The loop unroll transform is safe because it
only clones blocks in the loop body, it does not try to split critical
edges involving EH pads. Instead, move the necessary safety check to
LoopUnswitch.
N.B. The safety check for loop unswitch is covered by an existing test
which fails without it.
llvm-svn: 268357
Diffstat (limited to 'llvm/lib/Transforms/Scalar/LoopUnswitch.cpp')
-rw-r--r-- | llvm/lib/Transforms/Scalar/LoopUnswitch.cpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp b/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp index 310f41e..0e861b6 100644 --- a/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp +++ b/llvm/lib/Transforms/Scalar/LoopUnswitch.cpp @@ -500,6 +500,11 @@ bool LoopUnswitch::processCurrentLoop() { if (!CS) continue; if (CS.hasFnAttr(Attribute::Convergent)) return false; + // Return false if any loop blocks contain invokes whose predecessor edges + // we cannot split. + if (auto *II = dyn_cast<InvokeInst>(&I)) + if (!II->getUnwindDest()->canSplitPredecessors()) + return false; } } |