diff options
author | Benjamin Kramer <benny.kra@googlemail.com> | 2015-05-29 19:43:39 +0000 |
---|---|---|
committer | Benjamin Kramer <benny.kra@googlemail.com> | 2015-05-29 19:43:39 +0000 |
commit | f5e2fc474db076f35e8badb239661cbf283d5003 (patch) | |
tree | 21e3a8e7fb1fd4be46a5f3b0f8796988ea04e3a2 /llvm/lib/Transforms/IPO/MergeFunctions.cpp | |
parent | 3204b152b53e539304f9da2aff100876aeefa856 (diff) | |
download | llvm-f5e2fc474db076f35e8badb239661cbf283d5003.zip llvm-f5e2fc474db076f35e8badb239661cbf283d5003.tar.gz llvm-f5e2fc474db076f35e8badb239661cbf283d5003.tar.bz2 |
Replace push_back(Constructor(foo)) with emplace_back(foo) for non-trivial types
If the type isn't trivially moveable emplace can skip a potentially
expensive move. It also saves a couple of characters.
Call sites were found with the ASTMatcher + some semi-automated cleanup.
memberCallExpr(
argumentCountIs(1), callee(methodDecl(hasName("push_back"))),
on(hasType(recordDecl(has(namedDecl(hasName("emplace_back")))))),
hasArgument(0, bindTemporaryExpr(
hasType(recordDecl(hasNonTrivialDestructor())),
has(constructExpr()))),
unless(isInTemplateInstantiation()))
No functional change intended.
llvm-svn: 238602
Diffstat (limited to 'llvm/lib/Transforms/IPO/MergeFunctions.cpp')
-rw-r--r-- | llvm/lib/Transforms/IPO/MergeFunctions.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/Transforms/IPO/MergeFunctions.cpp b/llvm/lib/Transforms/IPO/MergeFunctions.cpp index 91a5eef..1327645 100644 --- a/llvm/lib/Transforms/IPO/MergeFunctions.cpp +++ b/llvm/lib/Transforms/IPO/MergeFunctions.cpp @@ -1465,7 +1465,7 @@ void MergeFunctions::remove(Function *F) { if (Erased) { DEBUG(dbgs() << "Removed " << F->getName() << " from set and deferred it.\n"); - Deferred.push_back(F); + Deferred.emplace_back(F); } } |