diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-01-01 22:29:43 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-01-01 22:29:43 +0000 |
commit | 6994fdf33ca0853be55b7db01f7320c42441a79b (patch) | |
tree | 3e717209816c3396d9a320d32132cdde4c9a97c0 /llvm/lib/Target/X86/X86TargetMachine.cpp | |
parent | 9a3da52ea2dd0a3d40c7d6addeadde7d4f6cdd9d (diff) | |
download | llvm-6994fdf33ca0853be55b7db01f7320c42441a79b.zip llvm-6994fdf33ca0853be55b7db01f7320c42441a79b.tar.gz llvm-6994fdf33ca0853be55b7db01f7320c42441a79b.tar.bz2 |
Remove the 's' DataLayout specification
During the years there have been some attempts at figuring out how to
align byval arguments. A look at the commit log suggests that they
were
* Use the ABI alignment.
* When that was not sufficient for x86-64, I added the 's' specification to
DataLayout.
* When that was not sufficient Evan added the virtual getByValTypeAlignment.
* When even that was not sufficient, we just got the FE to add the alignment
to the byval.
This patch is just a simple cleanup that removes my first attempt at fixing the
problem. I also added an AArch64 implementation of getByValTypeAlignment to
make sure this patch is a nop. I also left the 's' parsing for backward
compatibility.
I will send a short email to llvmdev about the change for anyone maintaining
an out of tree target.
llvm-svn: 198287
Diffstat (limited to 'llvm/lib/Target/X86/X86TargetMachine.cpp')
-rw-r--r-- | llvm/lib/Target/X86/X86TargetMachine.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/llvm/lib/Target/X86/X86TargetMachine.cpp b/llvm/lib/Target/X86/X86TargetMachine.cpp index 04c1d7e..773d702 100644 --- a/llvm/lib/Target/X86/X86TargetMachine.cpp +++ b/llvm/lib/Target/X86/X86TargetMachine.cpp @@ -53,10 +53,6 @@ static std::string computeDataLayout(const X86Subtarget &ST) { else Ret += "-f80:32"; - // Objects on the stack ore aligned to 64 bits. - if (ST.is64Bit()) - Ret += "-s:64"; - // The registers can hold 8, 16, 32 or, in x86-64, 64 bits. if (ST.is64Bit()) Ret += "-n8:16:32:64"; |