aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp
diff options
context:
space:
mode:
authorJames Henderson <jh7370@my.bristol.ac.uk>2019-02-04 16:17:57 +0000
committerJames Henderson <jh7370@my.bristol.ac.uk>2019-02-04 16:17:57 +0000
commit9652652a321de828e6d7efb9f16fd91cf7e95788 (patch)
tree7eca20b8a159ccf04505776ee715c2362463f890 /llvm/lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp
parent0c599c388dbb4c5852019c90eeb642839dc52ebe (diff)
downloadllvm-9652652a321de828e6d7efb9f16fd91cf7e95788.zip
llvm-9652652a321de828e6d7efb9f16fd91cf7e95788.tar.gz
llvm-9652652a321de828e6d7efb9f16fd91cf7e95788.tar.bz2
[CommandLine] Don't print empty sentinel values from EnumValN lists in help text
In order to make an option value truly optional, both the ValueOptional attribute and an empty-named value are required. Prior to this change, this empty-named value appears in the command-line help text: -some-option - some help text =v1 - description 1 =v2 - description 2 = - This change improves the help text for these sort of options in a number of ways: 1) ValueOptional options with an empty-named value now print their help text twice: both without and then with '=<value>' after the name. The latter version then lists the allowed values after it. 2) Empty-named values with no help text in ValueOptional options are not listed in the permitted values. -some-option - some help text -some-option=<value> - some help text =v1 - description 1 =v2 - description 2 3) Otherwise empty-named options are printed as =<empty> rather than simply '='. 4) Option values without help text do not have the '-' separator printed. -some-option=<value> - some help text =v1 - description 1 =v2 =<empty> - description It also tweaks the llvm-symbolizer -functions help text to not print a trailing ':' as that looks bad combined with 1) above. This is mostly a reland of r353048 which in turn was a reland of r352750. Reviewed by: ruiu, thopre, mstorsjo Differential Revision: https://reviews.llvm.org/D57030 llvm-svn: 353053
Diffstat (limited to 'llvm/lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp')
0 files changed, 0 insertions, 0 deletions