diff options
author | Adrian Vogelsgesang <avogelsgesang@salesforce.com> | 2024-09-17 02:18:52 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-09-17 02:18:52 +0200 |
commit | 0cc2cd781594aec741f7262df7a48d73a7d09a18 (patch) | |
tree | d0c7a8c7cee3fb42199b7ae5c2316b1a04a79c09 /llvm/lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp | |
parent | d9045420ae8c1b986232a44b9e3073793eec7f8a (diff) | |
download | llvm-0cc2cd781594aec741f7262df7a48d73a7d09a18.zip llvm-0cc2cd781594aec741f7262df7a48d73a7d09a18.tar.gz llvm-0cc2cd781594aec741f7262df7a48d73a7d09a18.tar.bz2 |
[lldb-dap] Provide `declarationLocation` for variables (#102928)
This commit implements support for the "declaration location" recently
added by microsoft/debug-adapter-protocol#494 to the debug adapter
protocol.
For the `declarationLocationReference` we need a variable ID similar to
the `variablesReference`. I decided to simply reuse the
`variablesReference` here and renamed `Variables::expandable_variables`
and friends accordingly. Given that almost all variables have a
declaration location, we now assign those variable ids to all variables.
While `declarationLocationReference` effectively supersedes
`$__lldb_extensions.declaration`, I did not remove this extension, yet,
since I assume that there are some closed-source extensions which rely
on it.
I tested this against VS-Code Insiders. However, VS-Code Insiders
currently only supports `valueLoctionReference` and not
`declarationLocationReference`, yet. Locally, I hence published the
declaration locations as value locations, and VS Code Insiders navigated
to the expected places. Looking forward to proper VS Code support for
`declarationLocationReference`.
Diffstat (limited to 'llvm/lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp')
0 files changed, 0 insertions, 0 deletions